Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Make [KO],[ES], [PT] translations publishable #1603

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

ilyaspiridonov
Copy link
Contributor

Made Korean, Spanish and Portuguese translations publishable:

  • updated config.yaml to include the three languages in the build;
  • added toc.yaml for each of the three languages. Section names are Google-translated.

NB Bengali and Chinese can not be added until #1602 is resolved.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@clausia
Copy link
Contributor

clausia commented Oct 3, 2022

To publish each language, I thought we should follow this guide
https://github.com/Qiskit/platypus/blob/main/translations/release_guide.md

On the other hand, the translated toc.yaml file must be proofread before merging, isn't it?

@ilyaspiridonov
Copy link
Contributor Author

ilyaspiridonov commented Oct 3, 2022

Thank you @clausia, this PR basically does what is described in the Release Guide.
This is intended to lower the bar for the community to make new translated textbooks publishable (as right now the project has some notebooks available in 5 languages, but none of those have made it to the production release yet ;)

Regarding proofreading - good point, I used Google Translate here as the initial translation, and the community can later improve if necessary (or review here in this PR).
The translations are only the section titles (not textbook titles and TOC items, as those are parsed directly from the translated textbooks).

@vabarbosa vabarbosa changed the base branch from main to feat/translations October 3, 2022 17:14
Copy link
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyaspiridonov thank you for getting this started. i switched the base branch to feat/translations (instead of main) that way we can set up/generate preview URL with the changes before pushing to main.

@vabarbosa vabarbosa merged commit 630b766 into Qiskit:feat/translations Oct 3, 2022
@vabarbosa vabarbosa mentioned this pull request Oct 3, 2022
vabarbosa added a commit that referenced this pull request Oct 4, 2022
@0sophy1
Copy link
Contributor

0sophy1 commented Oct 6, 2022

@ilyaspiridonov Thank you so much..!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants