feat(1xp-banner): add banner to /signin, /account, and /error pages

[techtolentino]

Changes

Closes #2189

Implementation details

• added q-one-xp-banner to signin.pug, userAccount.pug, and error.pug templates
• pulled $one-xp-banner-height-* variables into the settings.scss since it's used in multiple scss files
• updated .sign-in styles to make banner work
  • note: I had to add a 1px to the top and max-height calculations so the bottom-border of the banner would show

Screenshots

Sign in and Account pages

Screen.Recording.2023-09-06.at.10.34.12.AM.mov

Error page

preview of sign in page: https://platypus-pr-2195.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/signin
preview of error page: https://platypus-pr-2195.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/test

[vabarbosa]

thank you! this looks good @techtolentino
i am approving so we can merge this but
while we are here you may want to confirm if banner should be included it on the following and if so maybe open/create new issue/PR

EULA page

404 page

syllabus pages

[techtolentino]

@vabarbosa - I thought about these pages but didn't fully know if they should be everywhere

maybe they should?

@y4izus?

[vabarbosa]

@vabarbosa - I thought about these pages but didn't fully know if they should be everywhere

at minimum i would say the 404 page should have the banner. i'm ok with leaving the other pages as is though.

[techtolentino]

at minimum i would say the 404 page should have the banner. i'm ok with leaving the other pages as is though.

@vabarbosa - good idea, updated here 1e9e6ab

[vabarbosa]

thank you @techtolentino!!!
looks good!

[y4izus]

I think is enough with that pages, so I'm gonna merge