-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code in 0.19 #10791
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs tests
are failing due to Qobj
in docstring
even after removal, please remove it from below line.
qiskit/qiskit/qobj/__init__.py
Line 26 in cd507ad
Qobj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @doublehoon! some small comments on the reno.
(and thanks @Raghav-Bell for the review)
releasenotes/notes/remove-deprecated-code-in-0.19-a97ccfec62405b9a.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/remove-deprecated-code-in-0.19-a97ccfec62405b9a.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/remove-deprecated-code-in-0.19-a97ccfec62405b9a.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work. Welcome to the project!
Summary
Remove deprecated code in 0.19
Details and comments
Fixes #10746
Please add
Changelog: Removal
label.