Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code in 0.19 #10791

Merged
merged 9 commits into from
Sep 16, 2023
Merged

Remove deprecated code in 0.19 #10791

merged 9 commits into from
Sep 16, 2023

Conversation

doublehoon
Copy link
Contributor

@doublehoon doublehoon commented Sep 7, 2023

Summary

Remove deprecated code in 0.19

Details and comments

Fixes #10746
Please add Changelog: Removal label.

@doublehoon doublehoon requested review from jyu00, a team and woodsp-ibm as code owners September 7, 2023 04:59
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 7, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @woodsp-ibm

@doublehoon doublehoon changed the title remove-deprecated-code-in-0.19 Remove deprecated code in 0.19 Sep 7, 2023
Copy link
Contributor

@Raghav-Bell Raghav-Bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs tests are failing due to Qobj in docstring even after removal, please remove it from below line.

@woodsp-ibm woodsp-ibm added the Changelog: Removal Include in the Removed section of the changelog label Sep 10, 2023
@1ucian0 1ucian0 self-assigned this Sep 11, 2023
@1ucian0 1ucian0 added this to the 0.45.0 milestone Sep 11, 2023
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @doublehoon! some small comments on the reno.

(and thanks @Raghav-Bell for the review)

Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work. Welcome to the project!

@1ucian0 1ucian0 added this pull request to the merge queue Sep 16, 2023
Merged via the queue into Qiskit:main with commit 2d3632f Sep 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove code deprecated in 0.19 (released on December 06, 2021)
5 participants