Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate contract secType on null #122

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Aug 30, 2024

Description

This update introduces a validation step to ensure that contract.SecType is not null before attempting to retrieve the correct SecurityType of the contract. If contract.SecType is null, the update will instead invoke the GetContractDetails() method using the comboLeg.ConId to retrieve the necessary details.

Related Issue

N/a

Motivation and Context

The current implementation assumes that contract.SecType is always populated, which may not be the case in certain scenarios. This can lead to incorrect or failed attempts to retrieve the SecurityType of a contract. By validating that contract.SecType is not null, we ensure that the logic for determining the SecurityType is robust and accurate. If contract.SecType is null, we use the GetContractDetails() method as a fallback mechanism, using comboLeg.ConId to retrieve the required information.

Requires Documentation Change

N/A

How Has This Been Tested?

  • run existing tests with ComboOrders

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes added the bug Something isn't working label Aug 30, 2024
@Romazes Romazes self-assigned this Aug 30, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Martin-Molinero Martin-Molinero merged commit 4e5685f into master Sep 4, 2024
1 check failed
@Martin-Molinero Martin-Molinero deleted the fix-missed-null-validation-security-type branch September 4, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants