Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use GroupOrderCacheManager #123

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Sep 4, 2024

Description

We have used Lean abstraction for GroupOrderCahceManger and eliminated some duplication in Interactive Brokers.

Related PRs

Related Issue

N/A

Motivation and Context

Reusing logic and creating some abstraction.

Requires Documentation Change

N/A

How Has This Been Tested?

Run all existing tests.

Example: ComboMarketOrder

image

Example: StopLimitOrder

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes self-assigned this Sep 4, 2024
@Romazes Romazes force-pushed the refactor-group-order-manager-process branch from 2c61d1a to 362ca3c Compare September 4, 2024 20:05
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

@Martin-Molinero Martin-Molinero merged commit 2c188c7 into master Sep 6, 2024
1 check failed
@Martin-Molinero Martin-Molinero deleted the refactor-group-order-manager-process branch September 6, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants