Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade to cmdr 1.12.0 to patch security vulnerability #384

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Quenty
Copy link
Owner

@Quenty Quenty commented Jul 10, 2023

Fixes this security advisory. See evaera/Cmdr#279.

This is from this republished version of Cmdr: https://github.com/QuentyStudios/cmdr

This upgrades this version to explicitly use this new version. Older versions should still include this patch depending on how the upstream npm registry is configured.

Summary

Initialisation scripts enable for users to save commands which can then be executed whenever they join. This may be useful for things like setting preferences, giving tools to themselves when joining, etc. depending on the game.

Until v1.12.0, Cmdr also supported global initialisation scripts; this allowed any user (with access to the var= command) to set commands that would be ran when any player with access to the var command would join. These commands would run as that user, including with any permissions held.

The impact of this vulnerability depends on your game and the type of commands you have. Imagine a game with a give_players_money command only accessible to administrators, but the var commands locked to moderators. A rogue moderator could set the initialisation script to give_players_money * 1000000 giving all players six figures of money whenever an administrator joins.

Security advisory: GHSA-4vh6-p9hm-qwrr

@Quenty Quenty merged commit aff0c49 into main Jul 10, 2023
3 checks passed
@Quenty Quenty deleted the users/quenty/cmdr branch July 10, 2023 19:45
@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant