Replace the "SessionAdmin" class' readonly_fields with has_add_permission and has_change_permission #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion and has_change_permission
|
Hi @ataylor32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you go to the "Add session" form (/admin/qsessions/session/add/), the following exception is thrown due to line 102 in admin.py:
But even if that bug wasn't present, there would be no point in going to the "Add session" form anyway since all of the fields are read-only.
Similarly, since all of the fields are read-only, the "Change session" form's "SAVE", "Save and add another", and "Save and continue editing" buttons are all kind of confusing since there's nothing to save.
This pull request disables adding and changing, which fixes the exception and makes the interface make more sense.