fix(v2): repl examples (#6897)

* throw error using qwik utils * fix repl examples * fix api
QwikDev · Sep 22, 2024 · cf77a1f · cf77a1f
1 parent a789e32
commit cf77a1f
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 20 deletions.
diff --git a/packages/docs/src/repl/monaco.tsx b/packages/docs/src/repl/monaco.tsx
@@ -148,7 +148,11 @@ const checkDiagnostics = async (
 ) => {
   if (!monacoCtx.tsWorker) {
     const getTsWorker = await monaco.languages.typescript.getTypeScriptWorker();
-    monacoCtx.tsWorker = await getTsWorker(editor.getModel()!.uri);
+    const uri = editor.getModel()?.uri;
+    if (!uri) {
+      return;
+    }
+    monacoCtx.tsWorker = await getTsWorker(uri);
   }
   const tsWorker = monacoCtx.tsWorker;
 

diff --git a/packages/docs/src/repl/worker/repl-request-handler.ts b/packages/docs/src/repl/worker/repl-request-handler.ts
@@ -169,5 +169,5 @@ const injectDevHtml = (clientId: string, html?: string) => {
   }, true);
 })();`;
 
-  return `<script>${s}</script>${html || ''}`;
+  return `<script :>${s}</script>${html || ''}`;
 };
diff --git a/packages/qwik/src/core/v2/client/dom-container.ts b/packages/qwik/src/core/v2/client/dom-container.ts
@@ -147,7 +147,7 @@ export class DomContainer extends _SharedContainer implements IClientContainer {
     );
     this.qContainer = element.getAttribute(QContainerAttr)!;
     if (!this.qContainer) {
-      throw new Error("Element must have 'q:container' attribute.");
+      throwErrorAndStop("Element must have 'q:container' attribute.");
     }
     this.$journal$ = [
       // The first time we render we need to hoist the styles.

diff --git a/packages/qwik/src/core/v2/client/process-vnode-data.ts b/packages/qwik/src/core/v2/client/process-vnode-data.ts
@@ -1,4 +1,5 @@
 // NOTE: we want to move this function to qwikloader, and therefore this function should not have any external dependencies
+import { throwErrorAndStop } from '../../util/log';
 import { VNodeDataChar, VNodeDataSeparator } from '../shared/vnode-data-types';
 import type { ContainerElement, ElementVNode, QDocument } from './types';
 
@@ -265,7 +266,7 @@ export function processVNodeData(document: Document) {
         do {
           islandNode = walker.nextNode();
           if (!islandNode) {
-            throw new Error(`Island inside <!--${node?.nodeValue}--> not found!`);
+            return throwErrorAndStop(`Island inside <!--${node?.nodeValue}--> not found!`);
           }
         } while (getFastNodeType(islandNode) !== NodeType.COMMENT_ISLAND_START);
         nextNode = null;
@@ -274,7 +275,7 @@ export function processVNodeData(document: Document) {
         do {
           nextNode = walker.nextNode();
           if (!nextNode) {
-            throw new Error(`Ignore block not closed!`);
+            return throwErrorAndStop(`Ignore block not closed!`);
           }
         } while (getFastNodeType(nextNode) !== NodeType.COMMENT_IGNORE_END);
         nextNode = null;
@@ -284,7 +285,7 @@ export function processVNodeData(document: Document) {
         do {
           nextNode = nextSibling(nextNode);
           if (!nextNode) {
-            throw new Error(`<!--${node?.nodeValue}--> not closed!`);
+            return throwErrorAndStop(`<!--${node?.nodeValue}--> not closed!`);
           }
         } while (getFastNodeType(nextNode) !== NodeType.COMMENT_SKIP_END);
         // console.log('EXIT', nextNode?.outerHTML);

diff --git a/packages/qwik/src/core/v2/client/vnode-diff.ts b/packages/qwik/src/core/v2/client/vnode-diff.ts
@@ -101,6 +101,7 @@ import {
   clearSubscriberEffectDependencies,
   clearVNodeEffectDependencies,
 } from '../signal/v2-subscriber';
+import { throwErrorAndStop } from '../../util/log';
 
 export type ComponentQueue = Array<VNode>;
 
@@ -651,7 +652,7 @@ export const vnode_diff = (
         if (elementName === 'textarea' && key === 'value') {
           if (typeof value !== 'string') {
             if (isDev) {
-              throw new Error('The value of the textarea must be a string');
+              throwErrorAndStop('The value of the textarea must be a string');
             }
             continue;
           }

diff --git a/packages/qwik/src/core/v2/shared/scheduler.ts b/packages/qwik/src/core/v2/shared/scheduler.ts
@@ -93,7 +93,7 @@ import {
   type ResourceDescriptor,
   type TaskFn,
 } from '../../use/use-task';
-import { logWarn } from '../../util/log';
+import { logWarn, throwErrorAndStop } from '../../util/log';
 import { isPromise, maybeThen, maybeThenPassError, safeCall } from '../../util/promises';
 import type { ValueOrPromise } from '../../util/types';
 import { isDomContainer } from '../client/dom-container';
@@ -470,7 +470,7 @@ function choreComparator(a: Chore, b: Chore, shouldThrowOnHostMismatch: boolean)
         const errorMessage =
           'SERVER: during HTML streaming, it is not possible to cause a re-run of tasks on a different host';
         if (shouldThrowOnHostMismatch) {
-          throw new Error(errorMessage);
+          throwErrorAndStop(errorMessage);
         }
         logWarn(errorMessage);
         return null;

diff --git a/packages/qwik/src/core/v2/shared/shared-serialization.ts b/packages/qwik/src/core/v2/shared/shared-serialization.ts
@@ -308,7 +308,7 @@ const inflate = (container: DeserializeContainer, target: any, needsInflationDat
         : undefined;
       break;
     case SerializationConstant.Resource_VALUE:
-      throw new Error('Not implemented');
+      return throwErrorAndStop('Not implemented');
     case SerializationConstant.Component_VALUE:
       inflateQRL(container, target[SERIALIZABLE_STATE][0]);
       break;
@@ -378,7 +378,7 @@ const inflate = (container: DeserializeContainer, target: any, needsInflationDat
       propsProxy[_CONST_PROPS] = container.$getObjectById$(restInt()) as any;
       break;
     default:
-      throw new Error('Not implemented');
+      return throwErrorAndStop('Not implemented');
   }
   restIdx = restStack.pop() as number;
   rest = restStack.pop() as string;
@@ -393,7 +393,7 @@ const allocate = <T>(value: string): any => {
     case SerializationConstant.Task_VALUE:
       return new Task(-1, -1, null!, null!, null!, null);
     case SerializationConstant.Resource_VALUE:
-      throw new Error('Not implemented');
+      return throwErrorAndStop('Not implemented');
     case SerializationConstant.URL_VALUE:
       return new URL(value.substring(1));
     case SerializationConstant.Date_VALUE:
@@ -453,7 +453,7 @@ const allocate = <T>(value: string): any => {
     case SerializationConstant.PropsProxy_VALUE:
       return createPropsProxy(null!, null);
     default:
-      throw new Error('unknown allocate type: ' + value.charCodeAt(0));
+      return throwErrorAndStop('unknown allocate type: ' + value.charCodeAt(0));
   }
 };
 
@@ -761,7 +761,7 @@ export const createSerializationContext = (
               }
             }
           } else {
-            throw new Error('Unknown type: ' + obj);
+            return throwErrorAndStop('Unknown type: ' + obj);
           }
         } else if (id === Number.MIN_SAFE_INTEGER) {
           // We are seeing this object second time => promoted it.
@@ -841,7 +841,7 @@ function serialize(serializationContext: SerializationContext): void {
     } else if (typeof value === 'undefined') {
       writeString(SerializationConstant.UNDEFINED_CHAR);
     } else {
-      throw new Error('Unknown type: ' + typeof value);
+      return throwErrorAndStop('Unknown type: ' + typeof value);
     }
   };
 
@@ -996,7 +996,7 @@ function serialize(serializationContext: SerializationContext): void {
       const out = btoa(buf).replace(/=+$/, '');
       writeString(SerializationConstant.Uint8Array_CHAR + out);
     } else {
-      throw new Error('implement');
+      return throwErrorAndStop('implement');
     }
   };
 

diff --git a/packages/qwik/src/core/v2/signal/v2-signal.ts b/packages/qwik/src/core/v2/signal/v2-signal.ts
@@ -17,7 +17,7 @@ import { type QRLInternal } from '../../qrl/qrl-class';
 import type { QRL } from '../../qrl/qrl.public';
 import { trackSignal, tryGetInvokeContext } from '../../use/use-core';
 import { Task, TaskFlags, isTask } from '../../use/use-task';
-import { logError } from '../../util/log';
+import { logError, throwErrorAndStop } from '../../util/log';
 import { ELEMENT_PROPS, OnRenderProp, QSubscribers } from '../../util/markers';
 import { isPromise } from '../../util/promises';
 import { qDev } from '../../util/qdev';
@@ -222,7 +222,7 @@ export class Signal<T = any> extends Subscriber implements ISignal<T> {
   // prevent accidental use as value
   valueOf() {
     if (qDev) {
-      throw new TypeError('Cannot coerce a Signal, use `.value` instead');
+      return throwErrorAndStop('Cannot coerce a Signal, use `.value` instead');
     }
   }
 
@@ -476,7 +476,7 @@ export class ComputedSignal<T> extends Signal<T> {
   }
 
   set value(_: any) {
-    throw new TypeError('ComputedSignal is read-only');
+    throwErrorAndStop('ComputedSignal is read-only');
   }
 }
 
@@ -548,6 +548,6 @@ export class WrappedSignal<T> extends Signal<T> {
   }
 
   set value(_: any) {
-    throw new TypeError('WrappedSignal is read-only');
+    throwErrorAndStop('WrappedSignal is read-only');
   }
 }