Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qwik-city): usePreventNavigate #6825

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat(qwik-city): usePreventNavigate #6825

merged 2 commits into from
Sep 17, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Aug 26, 2024

this enables preventing navigation when the application state is dirty.

The API needs to be ratified still, so marking as draft even though everything works.

Please discuss in QwikDev/qwik-evolution#15

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 9043733

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Minor
eslint-plugin-qwik Minor
@builder.io/qwik Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 26, 2024

commit: 92c1ea7

npm i https://pkg.pr.new/@builder.io/qwik@6825
npm i https://pkg.pr.new/@builder.io/qwik-city@6825
npm i https://pkg.pr.new/eslint-plugin-qwik@6825
npm i https://pkg.pr.new/create-qwik@6825

Open in Stackblitz

Copy link
Contributor

github-actions bot commented Aug 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 9043733

@wmertens wmertens force-pushed the qc-dirty-navigate branch 2 times, most recently from 608bbc7 to ef659ad Compare September 16, 2024 17:56
@wmertens wmertens enabled auto-merge (rebase) September 16, 2024 18:03
@wmertens wmertens force-pushed the qc-dirty-navigate branch 3 times, most recently from 34c89d0 to f189350 Compare September 17, 2024 08:27
Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the hard work on this @wmertens ! 🙏

@wmertens wmertens merged commit 3125156 into main Sep 17, 2024
17 checks passed
@wmertens wmertens deleted the qc-dirty-navigate branch September 17, 2024 10:12
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants