Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENCODE_FOR_URI bug? #2151

Closed
tommycarstensen opened this issue Nov 9, 2022 · 0 comments · Fixed by #2314
Closed

ENCODE_FOR_URI bug? #2151

tommycarstensen opened this issue Nov 9, 2022 · 0 comments · Fixed by #2314
Assignees
@aucampia
Labels
bug Something isn't working confirmation needed The issue raises a potential bug that needs to be confirmed.

Comments

@tommycarstensen
Copy link

The function ENCODE_FOR_URI should convert forward slash characters / to %2F according to the W3 documentation on that function:
https://www.w3.org/TR/xpath-functions/#func-encode-for-uri

However, when running a running a query with ENCODE_FOR_URI in rdflib, that doesn't happen.
@aucampia aucampia added bug Something isn't working confirmation needed The issue raises a potential bug that needs to be confirmed. labels Mar 24, 2023
@aucampia aucampia self-assigned this Mar 25, 2023
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 25, 2023
@aucampia
fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions
ab531e0 
`ROUND` was not correctly rounding negative numbers towards positive infinity,
`ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include
fractional seconds.

This change corrects these issues.

- Closes <RDFLib#2151>.
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 25, 2023
@aucampia
fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions
c834a76 
`ROUND` was not correctly rounding negative numbers towards positive infinity,
`ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include
fractional seconds.

This change corrects these issues.

- Closes <RDFLib#2151>.
@aucampia aucampia mentioned this issue Mar 25, 2023
Merged
4 tasks
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 25, 2023
@aucampia
fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions
97f81f3 
`ROUND` was not correctly rounding negative numbers towards positive infinity,
`ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include
fractional seconds.

This change corrects these issues.

- Closes <RDFLib#2151>.
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 25, 2023
@aucampia
fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions
c7db012 
`ROUND` was not correctly rounding negative numbers towards positive infinity,
`ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include
fractional seconds.

This change corrects these issues.

- Closes <RDFLib#2151>.
aucampia added a commit that referenced this issue Mar 26, 2023
@aucampia
fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions (#2314)
af17916 
`ROUND` was not correctly rounding negative numbers towards positive infinity,
`ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include
fractional seconds.

This change corrects these issues.

- Closes <#2151>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aucampia aucampia

Labels
bug Something isn't working confirmation needed The issue raises a potential bug that needs to be confirmed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions aucampia/rdflib
2 participants
@tommycarstensen @aucampia