Feature prepareupdate #1624
Merged
Feature prepareupdate #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Looks great.
Notes for other reviewers: I checked that all uses of rdflib.plugins.sparql.algebra.translateUpdate will work with new return value, and they will since they all just pass to rdflib.plugins.sparql.update.evalUpdate's second parameter, update and this function was updated to access update.algebra instead of update.
aucampia
reviewed
Dec 28, 2021
nicholascar
approved these changes
Dec 28, 2021
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
Slightly speculative, other option is close #272 with
wontfixProposed Changes
Basically, follow the pattern established in
prepareQueryprepareUpdatetoprocessor.py