Remove (TypeCheck|SubjectType|PredicateType|ObjectType)Error and related
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
changed the title
(TypeCheck|SubjectType|PredicateType|ObjectType)Error and re…(TypeCheck|SubjectType|PredicateType|ObjectType)Error and related
aucampia
force-pushed
the
iwana-20220101T0023-broken_test_type_check
branch
2 times, most recently
from
408399f
to
2f6316e
Compare
aucampia
force-pushed
the
iwana-20220101T0023-broken_test_type_check
branch
from
2f6316e
to
6460fbb
Compare
…lated Also remove `check_(context|subject|predicate|object|statement|pattern)`. It seems nothing is using these exceptions and functions. Technically this does remove parts of the public API, but I would argue they are "buggy" parts as anything that use them would be sorely disappointed to find that the behaviour is not as expect, and these functions/exceptions don't serve any function related to the aim of RDFLib unless they are integrated with the rest of RDFLib.
aucampia
force-pushed
the
iwana-20220101T0023-broken_test_type_check
branch
from
6460fbb
to
436bc1e
Compare
|
I don't recall ever knowing or caring about these tests so I'm happy for them to be removed. |
nicholascar
approved these changes
Apr 15, 2022
ghost
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove
check_(context|subject|predicate|object|statement|pattern).It seems nothing is using these exceptions and functions.
Technically this does remove parts of the public API, but I would argue
they are "buggy" parts as anything that use them would be sorely
disappointed to find that the behaviour is not as expect, and these
functions/exceptions don't serve any function related to the aim of
RDFLib unless they are integrated with the rest of RDFLib.
I'm not sure this is the best approach, so any other options are welcome. Fixes #1641