Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trig GRAPH needs graphname (as in w3c-test:trig-graph-bad-01) #2469

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

WhiteGobo
Copy link
Contributor

Summary of changes

trig parser will now expect a graphname if Keyword GRAPH is used before {...}.
removed expected failure for testcase https://www.w3.org/2013/TrigTests/#trig-graph-bad-01

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Jul 4, 2023

Coverage Status

coverage: 90.903% (+0.002%) from 90.901% when pulling c1bbb72 on WhiteGobo:trig-xfail-GRAPH-only-with-name into afea615 on RDFLib:main.

@aucampia
Copy link
Member

aucampia commented Jul 4, 2023

Test file in question:

# GRAPH tests
PREFIX : <http://example/>
# GRAPH but no name - GRAPH is not used with the default graph
GRAPH { :s :p :o }

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, it looks good. I just made one suggestion regarding how the error is raised.

@aucampia
Copy link
Member

aucampia commented Jul 4, 2023

I will merge later this week.

@aucampia aucampia requested a review from a team July 4, 2023 20:08
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Jul 4, 2023
@aucampia aucampia added the ready to merge The PR will be merged soon if no further feedback is provided. label Jul 5, 2023
@aucampia aucampia merged commit 8c9608b into RDFLib:main Jul 5, 2023
20 checks passed
@WhiteGobo WhiteGobo deleted the trig-xfail-GRAPH-only-with-name branch September 24, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants