Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Modernize literal tests #2472

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jul 6, 2023

Summary of changes

This change moves tests out of classes and into top-level functions, and
merges some test functions that were testing the same thing.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This change moves tests out of classes and into top-level functions, and
merges some test functions that were testing the same thing.
@aucampia aucampia force-pushed the aucampia/20230706T0034-refresh-literal-tests branch from 08e4524 to 8db4fb0 Compare July 6, 2023 20:56
@aucampia aucampia requested a review from a team July 6, 2023 20:57
@aucampia aucampia added ready to merge The PR will be merged soon if no further feedback is provided. testing review wanted This indicates that the PR is ready for review labels Jul 6, 2023
@coveralls
Copy link

Coverage Status

coverage: 90.903%. remained the same when pulling 8db4fb0 on aucampia:aucampia/20230706T0034-refresh-literal-tests into 8c9608b on RDFLib:main.

@aucampia
Copy link
Member Author

aucampia commented Jul 6, 2023

This is mostly just cosmetic, and does not affect coverage.

@aucampia aucampia merged commit 0ea6ca5 into RDFLib:main Jul 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants