SPARQLStore: Use SPARQLWrapper for updates #397

uholzer · 2014-05-24T18:59:30Z

SPARQLStore was using its own implementation to send SPARQL Update requests.
I modified it to use SPARQLWrapper's update mechanism as it already does for queries.

Remaining problems to sort out before merge:

SPARQLWrapper does not allow to choose whether to send an update as application/x-www-form-urlencoded or as application/sparql-update. Since this has been possible with SPARQLStore, this currently breaks backwards compatibility of the API. See also Choose Content-type for Update Requests sparqlwrapper#28
I would have liked to get rid of the classes NSSPARQLWrapper and TraverseSPARQLResultDOM, but SPARQLWrapper doesn't seem to have similar capabilies.

fixes #392

New versions of SPARQLWrapper now support SPARQL updates too. Therefore the methods inherited from SPARQLWrapper should be used for updates instead of building the request manually. Drawback: The user can no longer set whether to send updates as application/sparql-update or application/x-www-form-urlencoded. This feature should be introduced in SPARQLWrapper and the old behavoiur in SPARQLStore restored.

Mainly, we don't need to handle our own connection anymore. The keep alive option of SPARQLWrapper is activated. Some other small changes to improve consistency.

Removed empty/unnecessary comments and improved existing one.

bcogrel · 2014-06-14T14:24:05Z

Cool, so we will be able to use setCredentials() for updates (fixes #343).

However, I noticed a bug when making a CREATE query:

graph.update("CREATE GRAPH <urn:graph>")

This query is not treated like a SPARQL Update query but is sent to the query endpoint as follows:

15:15:29 INFO  [1] POST http://localhost:3030/ukpp/query
15:15:29 INFO  [1]   Host                 localhost:3030
15:15:29 INFO  [1]   Accept               application/sparql-results+xml
15:15:29 INFO  [1]   Content-Length       76
15:15:29 INFO  [1]   Content-Type         application/x-www-form-urlencoded
15:15:29 INFO  [1]   Connection           close
15:15:29 INFO  [1]   User-Agent           sparqlwrapper 1.6.0 (http://sparql-wrapper.sourceforge.net/)
15:15:29 INFO  [1]   Accept-Encoding      identity
15:15:29 WARN  SPARQL Query: Unrecognize request parameter (ignored): results
15:15:29 INFO  [1] Query = 


CREATE GRAPH <urn:graph>
15:15:29 INFO  [1]   Access-Control-Allow-Origin *
15:15:29 INFO  [1]   Server               Fuseki (1.0.1)
15:15:29 INFO  [1] 400 Parse error: 


CREATE GRAPH <urn:graph>
Encountered " "create" "CREATE "" at line 3, column 1.
Was expecting one of:
    "base" ...
    "prefix" ...
    "select" ...
    "describe" ...
    "construct" ...
    "ask" ...
     (53 ms)

Instead of (with the current implementation)

15:17:11 INFO  [1] POST http://localhost:3030/ukpp/update
15:17:11 INFO  [1]   Host                 localhost:3030
15:17:11 INFO  [1]   Content-Length       40
15:17:11 INFO  [1]   Content-Type         application/x-www-form-urlencoded; charset=UTF-8
15:17:11 INFO  [1]   Connection           keep-alive
15:17:11 INFO  [1]   Accept-Encoding      identity
15:17:11 INFO  [1] Form update = 

CREATE GRAPH <urn:graph>
15:17:11 INFO  [1]   Content-Type         text/html
15:17:11 INFO  [1]   Access-Control-Allow-Origin *
15:17:11 INFO  [1]   Server               Fuseki (1.0.1)
15:17:11 INFO  [1] 200 OK (85 ms)

wikier · 2014-06-14T14:58:30Z

guys, feel free to push to SPARQLWrapper whatever missing feature required for a better integration

bcogrel · 2014-06-14T18:53:57Z

Ok, I have submitted a pull request RDFLib/sparqlwrapper#29 to fix the regression I have mentioned.

wikier · 2014-06-15T16:30:33Z

great, pull request RDFLib/sparqlwrapper#29 merged on master

bcogrel · 2014-06-15T18:02:03Z

Thanks!

uholzer · 2014-06-29T14:21:51Z

As I see, RDFLib/sparqlwrapper#28 is the only remaining issue wee have to address?

bcogrel · 2014-06-29T18:58:39Z

A priori, yes. But I cannot fully tested this branch because it does not include recent commits of the master branch (named graph support).

Support for named graphs in the SPARQLUpdateStore is required for further development. Conflicts: rdflib/plugins/stores/sparqlstore.py

uholzer · 2014-07-04T18:21:03Z

There you go.

bcogrel · 2014-07-06T07:35:52Z

Thanks.

Ok, no problem detected while running the unittests of OldMan with Fuseki (mem and TDB) on Python 2.7. Looks good.

Thanks to the newly introduced method `setUpdateMethod` of the SPARQLWrapper, the user can again choose whether to send SPARQL Updates as `application/sparql-update` or as `application/x-www-form-urlencoded`.

uholzer · 2014-07-20T13:36:21Z

Clearly, the travis build is failing because the spaqlstore tries to import newly introduced symbols from SPARQLWrapper which are not available in the latest release. The error message is a bit misleading as it claims that SPARQLWrapper is not installed at all. (Maybe I should make the import warning more clear or remove it entirely.)

Question is, what to do now? Wait with merging until the next release of SPARQLWrapper is published?

wikier · 2014-07-20T16:51:49Z

Sorry guys, as soon as we'll fix RDFLib/sparqlwrapper#17 release 1.6.1 will be out to not block this anymore.

wikier · 2014-07-21T14:57:41Z

SPARQLWrapper 1.6.1 has been released, but you should update this PR to reflect the last-minute changes introduced by RDFLib/sparqlwrapper#28

Please, let us know any issue with this feature or with any other you might need.

This should work with SPARQLWrapper 1.6.1.

uholzer · 2014-07-26T16:10:42Z

Unfortunately, RDFLib/sparqlwrapper#35 causes trouble.

wikier · 2014-07-27T10:41:29Z

@uholzer that should be the single change, right. I preferred to do a last-minute change than deprecate the api later. Sorry.

uholzer · 2014-08-25T19:15:21Z

Okay. This works now together with the master branch of SPARQLWrapper thanks to @indeyets and @wikier. Once a new release of SPARQLWrapper has arrived, I will hit the merge button.

SPARQLStore: Use SPARQLWrapper for updates SPARQLStore was using its own implementation to send SPARQL Update requests. Now, it uses SPARQLWrapper's update mechanism in the same way it already uses its query mechanism.

uholzer · 2014-08-26T18:41:46Z

Finally, its done. Thanks to everyone involved!

uholzer added 3 commits May 24, 2014 19:06

Cleanups wrt. to usage of SPARQLWrapper

87bb2a3

Mainly, we don't need to handle our own connection anymore. The keep alive option of SPARQLWrapper is activated. Some other small changes to improve consistency.

Cleaned up some comments in SPARQLStore

a28c1b6

Removed empty/unnecessary comments and improved existing one.

bcogrel mentioned this pull request Jun 14, 2014

CREATE, CLEAR, DROP, LOAD, COPY and MOVE query types added RDFLib/sparqlwrapper#29

Merged

Merge branch 'master' into sparqlstore-sparqlwrapper

4d16390

Support for named graphs in the SPARQLUpdateStore is required for further development. Conflicts: rdflib/plugins/stores/sparqlstore.py

gromgull added the fix-in-progress label Jul 12, 2014

Restored functionality of option postAsEncoded

3659d9a

Thanks to the newly introduced method `setUpdateMethod` of the SPARQLWrapper, the user can again choose whether to send SPARQL Updates as `application/sparql-update` or as `application/x-www-form-urlencoded`.

wikier mentioned this pull request Jul 21, 2014

Choose Content-type for Update Requests RDFLib/sparqlwrapper#28

Closed

Method SPARQLWrapper.setUpdateMethod renamed to setRequestMethod

56274c7

This should work with SPARQLWrapper 1.6.1.

wikier mentioned this pull request Aug 26, 2014

Release 1.6.3 RDFLib/sparqlwrapper#40

Closed

uholzer merged commit af717b7 into master Aug 26, 2014

uholzer deleted the sparqlstore-sparqlwrapper branch August 26, 2014 18:43

bcogrel mentioned this pull request Aug 26, 2014

Why doesn't SPARQLUpdateStore support basic HTTP Auth? #343

Closed

joernhees modified the milestone: rdflib 4.2.0 Feb 19, 2015

joernhees added enhancement New feature or request SPARQL labels Feb 19, 2015

ocefpaf mentioned this pull request Apr 3, 2015

Updated rdflib. ioos/conda-recipes#177

Merged

pyup-bot mentioned this pull request Nov 8, 2016

Update rdflib to 4.2.1 mytardis/mytardis#733

Closed

This was referenced Jan 16, 2017

Initial Update mozilla/addons-server#4303

Closed

Update rdflib to 4.2.1 mozilla/addons-server#4390

Closed

pyup-bot mentioned this pull request Jan 29, 2017

Update rdflib to 4.2.2 mytardis/mytardis#815

Merged

This was referenced Mar 16, 2017

Initial Update mozilla/amo-validator#510

Closed

Update rdflib to 4.2.2 mozilla/amo-validator#515

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SPARQLStore: Use SPARQLWrapper for updates #397

SPARQLStore: Use SPARQLWrapper for updates #397

uholzer commented May 24, 2014

bcogrel commented Jun 14, 2014

wikier commented Jun 14, 2014

bcogrel commented Jun 14, 2014

wikier commented Jun 15, 2014

bcogrel commented Jun 15, 2014

uholzer commented Jun 29, 2014

bcogrel commented Jun 29, 2014

uholzer commented Jul 4, 2014

bcogrel commented Jul 6, 2014

uholzer commented Jul 20, 2014

wikier commented Jul 20, 2014

wikier commented Jul 21, 2014

uholzer commented Jul 26, 2014

wikier commented Jul 27, 2014

uholzer commented Aug 25, 2014

uholzer commented Aug 26, 2014

SPARQLStore: Use SPARQLWrapper for updates #397

SPARQLStore: Use SPARQLWrapper for updates #397

Conversation

uholzer commented May 24, 2014

bcogrel commented Jun 14, 2014

wikier commented Jun 14, 2014

bcogrel commented Jun 14, 2014

wikier commented Jun 15, 2014

bcogrel commented Jun 15, 2014

uholzer commented Jun 29, 2014

bcogrel commented Jun 29, 2014

uholzer commented Jul 4, 2014

bcogrel commented Jul 6, 2014

uholzer commented Jul 20, 2014

wikier commented Jul 20, 2014

wikier commented Jul 21, 2014

uholzer commented Jul 26, 2014

wikier commented Jul 27, 2014

uholzer commented Aug 25, 2014

uholzer commented Aug 26, 2014