-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #913 : Added _parseBoolean function to enforce correct Lexical-to-value mapping #995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add a test as well?
Where should I add the tests? Is there a specific file? |
https://github.com/RDFLib/rdflib/blob/master/test/test_literal.py should be the right place. |
test/test_literal.py
Outdated
@@ -163,6 +186,7 @@ def unlexify(s): | |||
self.assertEqual(specific_l.toPython(), s) | |||
self.assertEqual(specific_l.datatype, datatype) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this white space line. The rest is cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the whitespace line. Please let me know if any other changes are needed.
No description provided.