Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/pkg_u8g2: run the test in CI #11687

Merged
merged 1 commit into from
Aug 8, 2019
Merged

tests/pkg_u8g2: run the test in CI #11687

merged 1 commit into from
Aug 8, 2019

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 13, 2019 •
edited
Loading

Contribution description

Enable running the test as the test is available.

Testing procedure

The test must be successfully executed by CI (check the listed tests).

Issues/PRs references

Found it was not enabled while working on #11680
I blacklisted native due to #11691

@cladmi cladmi added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Jun 13, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 13, 2019
@cladmi cladmi mentioned this pull request Jun 13, 2019
Closed
@cladmi cladmi added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: run tests If set, CI server will run tests on hardware for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jun 14, 2019
@cladmi cladmi force-pushed the pr/tests/pkg_u8g2/enable_in_ci branch from 6ef93fe to d6d1f83 Compare June 25, 2019 14:36
@cladmi cladmi added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 25, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

I removed the murdock tests commits and changed to only enable what is working.

@cladmi cladmi requested a review from MrKevinWeiss June 25, 2019 15:29
MrKevinWeiss
MrKevinWeiss reviewed Jun 25, 2019
View reviewed changes
tests/pkg_u8g2/Makefile Outdated
@@ -59,4 +59,7 @@ CFLAGS += -DTEST_PIN_RESET=$(TEST_PIN_RESET)

CFLAGS += -DTEST_DISPLAY=$(TEST_DISPLAY)

# HACK Blacklist native as `murdock` fails on utf-8 characters for native tests
TEST_ON_CI_WHITELIST += nrf52dk samr21-xpro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to whitelist. What if other boards are added in (I think there is a pr for the esp)... Why not just use a blacklist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is currently not supported as TEST_ON_CI_BLACKLIST does not exist.

If you want I can split the variable introduction out of

@cladmi cladmi mentioned this pull request Jun 25, 2019
Merged
@cladmi
tests/pkg_u8g2: run the test in CI
50449b3 
HACK, the test currently fails in CI for `native` due to `utf-8` handling.
@cladmi cladmi force-pushed the pr/tests/pkg_u8g2/enable_in_ci branch from 2f93ff8 to 50449b3 Compare July 12, 2019 16:53
@cladmi
Copy link
Contributor Author

cladmi commented Jul 12, 2019

Rebased to use TESTS_ON_CI_BLACKLIST #11743.
I blacklisted native due to #11691

@fjmolinas fjmolinas self-requested a review August 2, 2019 14:45
fjmolinas
fjmolinas approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, murdock is green so ACK.

@fjmolinas fjmolinas merged commit ca2b008 into RIOT-OS:master Aug 8, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Aug 12, 2019

Thank you for the review.

@cladmi cladmi deleted the pr/tests/pkg_u8g2/enable_in_ci branch August 12, 2019 09:01
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss left review comments

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
4 participants
@cladmi @MrKevinWeiss @fjmolinas @kb2ma