usbus: simplify adding entry to list #11726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a code simplification albeit that it will now use a pointer-pointer
(which some may claim to add complexity).
The advantage is that no initial if is needed. And it's my believe that
a compiler will make fairly optimized code for it, even with the pointer-pointer.
The original code is this
and the new code is this
Testing procedure
That particalur USB code is fairly new and only used in
cdc_ecm.c
. Are thereactual USB tests (besides running some examples)?
Issues/PRs references
The code was recently added in #10916.