Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riotctrl_shell.gnrc: move compile object init to parser constructors #14462

Merged
merged 1 commit into from
Jul 9, 2020
Merged

riotctrl_shell.gnrc: move compile object init to parser constructors #14462

merged 1 commit into from
Jul 9, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 8, 2020

Contribution description

This way they are not initialized everytime the parse() method is called but only once at initialization of the parser.

Testing procedure

tools-test shall pass

Issues/PRs references

Follow-up on #11406.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tools Area: Supplementary tools labels Jul 8, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 8, 2020
@miri64 miri64 requested review from aabadie and bergzand July 8, 2020 10:41
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 8, 2020
@miri64 miri64 force-pushed the riotctrl_shell.gnrc/enh/compile-to-init branch from 9ce9192 to c3e6d89 Compare July 9, 2020 11:20
@miri64
Copy link
Member Author

miri64 commented Jul 9, 2020

Rebased and adapted for current master

aabadie
aabadie approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement and all checks are green.

ACK and go!

@aabadie aabadie merged commit 4dc82bc into RIOT-OS:master Jul 9, 2020
@miri64 miri64 deleted the riotctrl_shell.gnrc/enh/compile-to-init branch July 9, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @aabadie