examples/micropython: fix checked PID [backport 2020.07] #14530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: examples
miri64
force-pushed
the
backport/2020.07/examples/fix/micropython-14224
branch
from
006ed22
to
f0ba824
Compare
miri64
requested review from
cgundogan,
fjmolinas,
haukepetersen,
jia200x,
kaspar030,
leandrolanzieri,
MichelRottleuthner,
MrKevinWeiss,
PeterKietzmann and
smlng
as code owners
With RIOT-OS#14224 the idle thread became optional, so the main thread can have either 1 or 2 as PID, depending if the idle thread is included or not. As this might also change in the future, it is probably the best to just expect any number. (cherry picked from commit 5599b06)
|
Rebased to current release branch (with a little hick-up because I rebased to master by habbit...) needs a new ACK. |
miri64
force-pushed
the
backport/2020.07/examples/fix/micropython-14224
branch
from
f0ba824
to
649f461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14518
Contribution description
With #14224 the idle thread became optional, so the main thread can have either 1 or 2 as PID, depending if the idle thread is included or not. As this might also change in the future, it is probably the best to just expect any number.
Testing procedure
Should now succeed again on e.g. Cortex-M platforms.
Issues/PRs references
Follow-up on #14224