-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc/sock: recv avoid spinning xtimer #16831
Merged
benpicco
merged 1 commit into
RIOT-OS:master
from
kfessel:p-gnrc-short-recv-short-timeout
Sep 9, 2021
Merged
gnrc/sock: recv avoid spinning xtimer #16831
benpicco
merged 1 commit into
RIOT-OS:master
from
kfessel:p-gnrc-short-recv-short-timeout
Sep 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfessel
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
September 9, 2021 13:53
kfessel
added
the
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
label
Sep 9, 2021
benpicco
reviewed
Sep 9, 2021
Good catch! |
Just squash directly |
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Sep 9, 2021
kfessel
force-pushed
the
p-gnrc-short-recv-short-timeout
branch
from
September 9, 2021 14:22
2b560b7
to
6e5ddc3
Compare
benpicco
approved these changes
Sep 9, 2021
my gcc says this:
|
kaspar030
reviewed
Sep 9, 2021
kaspar030
reviewed
Sep 9, 2021
kfessel
force-pushed
the
p-gnrc-short-recv-short-timeout
branch
from
September 9, 2021 15:15
6e5ddc3
to
9975e05
Compare
benpicco
reviewed
Sep 9, 2021
kfessel
force-pushed
the
p-gnrc-short-recv-short-timeout
branch
from
September 9, 2021 15:16
9975e05
to
d192024
Compare
Might also need to be fixed in the other |
(but that can be done as a follow-up) |
Hm, now |
kfessel
force-pushed
the
p-gnrc-short-recv-short-timeout
branch
from
September 9, 2021 20:42
d192024
to
be28c53
Compare
special case of 0 timout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: network
Area: Networking
Area: sys
Area: System
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
avoid spinning xtimer on socket receive with short timeout by increasing the timeout to XTIMER_BACKOFF
Testing procedure
run benchmark_udp with short intervalls
Issues/PRs references
possibly Fixes #16808