cpu/nrf51822: fixed timers #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Platform: ARM
|
@haukepetersen I'm going to test this patch on yunjia and arduino due. but it seems that all cortex based platforms are broken? |
|
not really broken, there are just some situations where they might break, some boards are just not running into that situation so far... |
|
tested with hwimer on yunjia -> works -> ACK |
|
will merge when #1824 is merged... |
|
@haukepetersen PR needs rebase |
haukepetersen
force-pushed
the
fix_nrf_timer
branch
from
b8fa89f
to
59c81d1
Compare
|
rebased |
haukepetersen
force-pushed
the
fix_nrf_timer
branch
from
59c81d1
to
12c6c03
Compare
|
again. |
haukepetersen
force-pushed
the
fix_nrf_timer
branch
2 times, most recently
from
cbf4d71
to
1b1f44c
Compare
adjusted for - pca10000 - pca10005 - yunjia-nrf51822
- changed TIMER_0 to be a 24-bit timer -> see Nordic PAN #32 - cleaned up timer initialization code - added check if an interrupt channel was active
|
ACK, could you open an issue for the corner case "callback set, overrun occurs, callback gets triggered too soon" |
|
done, see #2006 |
|
and go. |
haukepetersen
added a commit
that referenced
this pull request
Nov 12, 2014
cpu/nrf51822: fixed timers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1800
is rebased on #1824The
test/vtimer_msgis still not working correctly, but this seems to be realted to the vtimer implementation -> see #1828