Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: eliminate warning in hwtimer #1901

Merged
merged 2 commits into from
Oct 30, 2014
Merged

core: eliminate warning in hwtimer #1901

merged 2 commits into from
Oct 30, 2014

Conversation

OlegHahm
Copy link
Member

This initialized has actually no relevance and is just needed to
suppress a compiler warning.

@OlegHahm OlegHahm added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Oct 30, 2014
@OlegHahm OlegHahm mentioned this pull request Oct 30, 2014
Merged
@LudwigKnuepfer
Copy link
Member

I'd still rather remove the if (!inISR())'s.

@OlegHahm
Copy link
Member Author

Agreed and updated.

@OlegHahm OlegHahm removed the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Oct 30, 2014
@LudwigKnuepfer
Copy link
Member

@OlegHahm You have some stray commits here I guess.

@OlegHahm
Copy link
Member Author

oops, fixed

@Kijewski
Copy link
Contributor

ACK

@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 30, 2014
@haukepetersen
Copy link
Contributor

ACK when you change the commit message to something more meaningful...

@OlegHahm OlegHahm changed the title core: initialize warning core: eliminate warning Oct 30, 2014
@OlegHahm OlegHahm changed the title core: eliminate warning core: eliminate warning in hwtimer Oct 30, 2014
@haukepetersen
Copy link
Contributor

now it is: ACK when squashed :-)

@LudwigKnuepfer LudwigKnuepfer mentioned this pull request Oct 30, 2014
Closed
@OlegHahm
core: eliminate warning
9b1e180 
This initialized has actually no relevance and is just needed to
suppress a compiler warning.
@OlegHahm
core: update irq_arch documentation
4885690
@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 30, 2014
OlegHahm added a commit that referenced this pull request Oct 30, 2014
@OlegHahm
Merge pull request #1901 from OlegHahm/hwtimer_irq_fixup
3d0be08 
core: eliminate warning in hwtimer
@OlegHahm OlegHahm merged commit 3d0be08 into RIOT-OS:master Oct 30, 2014
@OlegHahm OlegHahm deleted the hwtimer_irq_fixup branch October 30, 2014 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlegHahm @LudwigKnuepfer @Kijewski @haukepetersen