rbuf: does not remove oldest entry if we have entry for current fragment #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yonezawa-T2
added
Type: enhancement
|
This PR should be able to be independent from #4770 |
Yonezawa-T2
force-pushed
the
rbuf_gc_improvement
branch
4 times, most recently
from
cec3ba6
to
561185c
Compare
Yonezawa-T2
force-pushed
the
rbuf_gc_improvement
branch
from
561185c
to
9548cf5
Compare
|
Rebased. Now independent from #4770. |
|
@authmillenon, did you find time to review? |
OlegHahm
added
the
Community: Hack'n'ACK candidate
|
Will use the Hack'n'ACK for that. |
|
I actually DID review it yesterday but somehow forgot to comment: Looks good code-wise, but I'm not sure how to test. :-) |
|
(I guess if fragmentation is still working we are fine, will test so) |
miri64
added
CI: needs squashing
|
Reassembly still works: ACK. Please squash. |
miri64
added
the
CI: ready for build
If all rbuf slots are in use, `_rbuf_gc` removes the oldest entry even if the entry for the current fragment exists. This effectively decreases usable slots by one. This patch makes `_rbuf_gc` removes the oldest entry only if there is no entry for the current fragment.
Yonezawa-T2
force-pushed
the
rbuf_gc_improvement
branch
from
9548cf5
to
31fa340
Compare
|
Squashed. |
OlegHahm
removed
the
CI: needs squashing
miri64
added a commit
that referenced
this pull request
Mar 4, 2016
rbuf: does not remove oldest entry if we have entry for current fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all rbuf slots are in use,
_rbuf_gcremoves the oldest entry even if the entry for the current fragment exists. This effectively decreases usable slots by one. This patch makes_rbuf_gcremoves the oldest entry only if there is no entry for the current fragment.Depends on #4770.
This is a remainder of #4547.