Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/sodaq-explorer: add configuration for rn2483 module #7733

Merged
merged 1 commit into from
Jan 18, 2018
Merged

boards/sodaq-explorer: add configuration for rn2483 module #7733

merged 1 commit into from
Jan 18, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Oct 13, 2017 •
edited
Loading

Follow-up of #7725 with #7505.

@aabadie aabadie requested a review from keestux October 13, 2017 09:22
@aabadie aabadie added Area: boards Area: Board ports Area: LoRa Area: LoRa radio support labels Oct 13, 2017
@aabadie aabadie added this to the Release 2017.10 milestone Oct 13, 2017
@aabadie aabadie force-pushed the board/lorawan-explorer_rn2483 branch from b278d30 to 86f1c8e Compare October 13, 2017 12:35
@aabadie aabadie added the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 13, 2017
@keestux
Copy link
Contributor

keestux commented Oct 14, 2017

@aabadie Do you happen to know if I can somehow use the USB (ttyACM0) of the Explorer board as the serial for printf and getline (stdin, stdout)? (Instead of uart0)

@aabadie aabadie force-pushed the board/lorawan-explorer_rn2483 branch from 86f1c8e to 961340e Compare October 14, 2017 21:43
@aabadie
Copy link
Contributor Author

aabadie commented Oct 14, 2017

Do you happen to know if I can somehow use the USB (ttyACM0) of the Explorer board as the serial for printf and getline (stdin, stdout)?

Not for the moment with RIOT. This requires the support of the USB stack to emulate UART other USB. With this, one can have the same behaviour as with Arduino. There are discussions about this in #7510 (because Adafruit Feather M0 has the same 'problem') and in this old PR #3890 which is about adding an USB stack.

@aabadie aabadie force-pushed the board/lorawan-explorer_rn2483 branch from 961340e to 4e0c95c Compare December 14, 2017 16:39
@aabadie aabadie force-pushed the board/lorawan-explorer_rn2483 branch from 4e0c95c to 3b7ecf8 Compare December 22, 2017 06:47
@aabadie aabadie mentioned this pull request Jan 16, 2018
Merged
@smlng smlng removed this from the Release 2018.01 milestone Jan 18, 2018
@aabadie aabadie force-pushed the board/lorawan-explorer_rn2483 branch from 3b7ecf8 to d5aa10b Compare January 18, 2018 09:49
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 18, 2018
@aabadie
Copy link
Contributor Author

aabadie commented Jan 18, 2018

Once #7505 is in this one can be merged right away. I just tested it and it works.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 18, 2018
@aabadie aabadie force-pushed the board/lorawan-explorer_rn2483 branch from d5aa10b to bcce935 Compare January 18, 2018 14:40
@aabadie
Copy link
Contributor Author

aabadie commented Jan 18, 2018

We just made some testing with @kYc0o, so can this still be part of 2018.01 @smlng ?

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 18, 2018
@smlng smlng added this to the Release 2018.01 milestone Jan 18, 2018
@smlng
Copy link
Member

smlng commented Jan 18, 2018 •
edited
Loading

some testing with @kYc0o,

can we have @kYc0o`s approval then?

@kYc0o
Copy link
Contributor

kYc0o commented Jan 18, 2018

Do you happen to know if I can somehow use the USB (ttyACM0) of the Explorer board as the serial for printf and getline (stdin, stdout)?

Not for the moment with RIOT. This requires the support of the USB stack to emulate UART other USB. With this, one can have the same behaviour as with Arduino. There are discussions about this in #7510 (because Adafruit Feather M0 has the same 'problem') and in this old PR #3890 which is about adding an USB stack.

AFAIK what I understand from that is that there is already an USB-Serial converter (if you can see a /dev/ttyACMx). Thus it's a matter of knowing where is it mapped. Should be straightforward and would be much more practical.

kYc0o
kYc0o approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK.

@smlng
Copy link
Member

smlng commented Jan 18, 2018

great!

@smlng smlng merged commit 7c69e3b into RIOT-OS:master Jan 18, 2018
@aabadie aabadie deleted the board/lorawan-explorer_rn2483 branch February 26, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kYc0o kYc0o kYc0o approved these changes

@keestux keestux Awaiting requested review from keestux

Assignees

@keestux keestux

Labels
Area: boards Area: Board ports Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @keestux @smlng @kYc0o