This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
[Flang][OpenMP][MLIR] Create lifetime markers for allocations only used within OpenMP loop regions #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed within OpenMP loop regions By creating `llvm.lifetime.start` and `llvm.lifetime.end` markers for outside allocations around the body of the loop produced for `omp.wsloop` and `omp.simdloop` MLIR operations, later uses of the LLVM `CodeExtractor` class to potentially outline the body of these loops into independent functions will be able to see the reduced scope of use of these allocations and sink them into the outlined function's body rather than to unnecessarily pass them as arguments. This can also help later optimization stages to detect cases where allocations for loop indices are redundant.
skatrak
force-pushed
the
lifetime_alloca_loop
branch
from
ff9c6db
to
f1d4e7c
Compare
gregrodgers
merged commit 26c4106
into
ROCm-Developer-Tools:amd-trunk-dev
2 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating
llvm.lifetime.startandllvm.lifetime.endmarkers for outside allocations around the body of the loop produced foromp.wsloopandomp.simdloopMLIR operations, later uses of the LLVMCodeExtractorclass to potentially outline the body of these loops into independent functions will be able to see the reduced scope of use of these allocations and sink them into the outlined function's body rather than to unnecessarily pass them as arguments. This can also help later optimization stages to detect cases where allocations for loop indices are redundant.Currently it doesn't provide any benefits if applied on its own, but it improves the code generated for target worksharing loop in PR #231.