Mehmetb/fix tests #12
Conversation
Test was failing because of a deps update: @types/node The test was depending @types/node to be at version 15.0.1 but at the time of this commit @types/node was 15.6.0. I have added a dev dependency (@types/mssql@6.0.8) and set the package.json deps entry to match this version exactly. Signed-off-by: Mehmet Baker <mehmet@mehmetbaker.dev>
Signed-off-by: Mehmet Baker <mehmet@mehmetbaker.dev>
|
I haven't noticed that this project was using yarn until the CI check failure 😄 I was using npm. Since you might still want to merge I'm keeping the branch open. |
|
Hi @mehmetb , thank you so much for this PR! And please excuse that I respond that late - for some reason I do not see any notification messages in my inbox and this really is just a minor project of mine, as in the main point I have family and kids, a full time job and hobbies besides coding. Yet, I am happy to maintain this project and even so more to see people contributing! I just released version 2.0.0, with the main change (which is potentially a breaking change, therefore the new major version) being that the license-checker now exits when it receives unknown options. At the same time, I also realized the bug you filed and fixed it. In fact the tests are a thorn in my side - they still come from the original license-checker from Dave Glass and are pretty old. I want to switch to Jest soon and re-do all the tests, as I have experience with Jest, but not with Mocha. Also, I should definitely switch to TDD, so that errors like this can not happen any more. But these two things are related to each other. I will set up TDD once I switch to Jest. So I hope it's ok for you if I just recommend version 2.0.0? But if you want, I can release a maintenance 1.2.x-version fixing that bug, which 'only' affects the tests. Cheers, Roman. |
|
I just merged your PR and released it as version 2.1.0, thus now including type support for mssql. Cheers, Roman. |
'should restrict the output to the provided packages' was failing since it was depending @types/node to be at version 15.0.1; but this module is now at version 15.6.0 and causes this test to fail.
Added @types/mssql version 6.0.8 as dev dependency and set its version in package.json to match 6.0.8 version exactly. Modified the test to check @types/mssql's version instead and now it passes.