Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate required node version #22

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Indicate required node version #22

merged 1 commit into from
Jan 31, 2022

Conversation

Backfighter
Copy link
Contributor

Since the code uses optional chaining it requires node >=14 to run (https://node.green/#ES2020-features-optional-chaining-operator-----). This should be indicated in the package json.

@Backfighter
Indicate required node version
ddba2d0 
Since the code uses optional chaining it requires node >=14 to run (https://node.green/#ES2020-features-optional-chaining-operator-----). This should be indicated in the package json.
RSeidelsohn
RSeidelsohn approved these changes Jan 31, 2022
View reviewed changes
Copy link
Owner

@RSeidelsohn RSeidelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks for keeping note of this. WIll release this as a bugfix version, as I see the lack of this indication a bug.

@RSeidelsohn RSeidelsohn merged commit 995f1fb into RSeidelsohn:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSeidelsohn RSeidelsohn RSeidelsohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Backfighter @RSeidelsohn