Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nopeer option for ignoring peerDependencies. Add typings #25

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

Semigradsky
Copy link
Contributor

@Semigradsky Semigradsky commented Nov 18, 2021

Currently peerDependencies are not installed automatically. This option is needed for avoiding to have package B in output if it is a devDependency and peerDependency of dependency A (if we no need to check devDependencies):

Project
|
| - A (dependency)
|   | - B (peerDependency)
|
| - B (devDependency) 

Also add typings. Fixes #21

@Semigradsky Semigradsky changed the title Add nopeer option for ignoring peerDependencies. Add nopeer option for ignoring peerDependencies. Add typings Nov 18, 2021
@arsinclair
Copy link

Thank you for this PR!

@RSeidelsohn could we have this PR reviewed? Having types would help a lot.

Copy link
Owner

@RSeidelsohn RSeidelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your efforts and please apologize me reacting so late!
I really appreciate your input and esp. the typings!

@RSeidelsohn RSeidelsohn merged commit f4216ae into RSeidelsohn:master Jan 31, 2022
@RSeidelsohn
Copy link
Owner

Ah damn, we should've increased the version number. Will do that later.

@RSeidelsohn
Copy link
Owner

Done, this is version 2.3.0. A new verison will follow soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide typings
3 participants