Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New major release 4 #53

Merged
merged 17 commits into from
Jan 21, 2023
Merged

New major release 4 #53

merged 17 commits into from
Jan 21, 2023

Conversation

RSeidelsohn
Copy link
Owner

  • Add ESlint
  • Add pre-commit-hook
  • Require NodeJS >= 18 and npm ^8
  • Update README file
  • Add .editorconfig file

Roman Seidelsohn added 17 commits January 21, 2023 20:35
chore: Bump to new major version
e13662b 
The real change leading to this major version increase will follow.
build: Require a NodeJS version of 18
9e42dfd 
This decision has been made due to soon ending security support for
versions 14 and 16.
From now on it is not guaranteed any more that this tool will work under
NodeJS < v16.
config: Update package-lock.json
60c1f4d 
This updates the file format of the package-lock.json from
lockfileVersion 1 to lockfileVersion 2 as well as some dependencies:

```
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

removed 3 packages, and audited 491 packages in 24s

65 packages are looking for funding
  run `npm fund` for details

flat  <5.0.1
Severity: critical
flat vulnerable to Prototype Pollution - GHSA-2j2x-2gpw-g8fm
fix available via `npm audit fix --force`
Will install jenkins-mocha@6.0.0, which is a breaking change
node_modules/flat
  yargs-unparser  <=1.6.3
  Depends on vulnerable versions of flat
  node_modules/yargs-unparser
    mocha  5.1.0 - 9.2.1
    Depends on vulnerable versions of minimatch
    Depends on vulnerable versions of yargs-unparser
    node_modules/mocha
      jenkins-mocha  >=7.0.0
      Depends on vulnerable versions of mocha
      node_modules/jenkins-mocha

minimatch  <3.0.5
Severity: high
minimatch ReDoS vulnerability - GHSA-f8q6-p94x-37v3
fix available via `npm audit fix --force`
Will install jenkins-mocha@6.0.0, which is a breaking change
node_modules/mocha/node_modules/minimatch

5 vulnerabilities (2 high, 3 critical)
```
docs: Add missing changes info to README file
fa3bf91 
Alas, I definitely let this hang loose too much. I should use a release-
checklist. But in order to think of it, I would need a think-of
checklist. Vicious circle.
docs: Add "draft mode" notice to SECURITY.md
7c286b4 
I just realized that this project now ha a SECURITY.md file. Never heard
of it before, but I love the idea and obviously have to get informed
about how this thing works. Hopefully there is some kind of automation
on GitHubs side for it?!
config: Add an .editorconfig file to the project
e6ac2ce 
I don't know why I did not have it from the beginning on - I love
.editorconfig files! It was about time to add it to this project.
config: Add NodeJS and npm version information to package.json
1b13ca4 
Unfortunately, this detail does not really what I want it to, but maybe
it's also a gift for now, as it does not prevent older NodeJS and npm
versions to work with release 4.0.0, which will of course work.

But still, since package.json offers this kind of information, I make
use of it.

Also, I re-ordered the attributes of the JSON file, as I felt that the
dependencies should go last. Might be that I (or you) will change my
mind on this again.
config: Add an .eslintignore file
ff295d1 
This was missing, I found.
config: Add directories to .prettierignore file
0ac0f4b 
These were missing, I found.
config: Remove outdated config option from .prettierrc
8bea56c
style: Delete trailing spaces from file
00d68a0 
This is a preparation for the introduction of ESlint
Add PrettierJS integration for ESlint and lint-staged
33379e3 
From now on, lint-staged should run PrettierJS and ESlint before every
commit. This is what we need.
config: Add the tasks needed for lint-staged
5878be2
config: Add prettier to the ESlint configuration
3a6a3ed
config: Add new prettier and lint tasks to our package.json file
e2a740d
build: Add husky for the pre-commit hook
fcc3393 
The pre-commit-hook should run lint-staged every time someone wants to
commit a file to the project.
config: Add pre-commit file for husky
1f45e6b 
I don't know - this new thing takes way too much time on every commit,
it seems. I probably will have to improve this pre-commit hook.
@RSeidelsohn RSeidelsohn merged commit 430ae0d into master Jan 21, 2023
@RSeidelsohn RSeidelsohn deleted the feature/new_major_release_4 branch January 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RSeidelsohn