Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #65

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Update README.md #65

merged 1 commit into from
Apr 1, 2023

Conversation

marcobiedermann
Copy link
Contributor

@marcobiedermann marcobiedermann commented Feb 21, 2023 •
edited
Loading

Use json5 instead of json to allow code comments

Before

image

After

image

@marcobiedermann
Update README.md
7fea720 
Use `json5` instead of `json` to allow code comments
@RSeidelsohn
Copy link
Owner

Oh, I didn't know that json5 exists. I just had a look at their intro and think that this is the way to go.
Thank you, @marcobiedermann, for creating this PR and thank you, @Saeger for the approval!

RSeidelsohn
RSeidelsohn approved these changes Apr 1, 2023
View reviewed changes
Copy link
Owner

@RSeidelsohn RSeidelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even know about json5 until now! Thanks a lot.

@RSeidelsohn RSeidelsohn merged commit 76c390e into RSeidelsohn:master Apr 1, 2023
@marcobiedermann marcobiedermann deleted the patch-1 branch April 3, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSeidelsohn RSeidelsohn RSeidelsohn approved these changes

@Saeger Saeger Saeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcobiedermann @RSeidelsohn @Saeger