-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar link's scroll position resolved. #194
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,8 +1,14 @@ | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
import React, { useState , useEffect } from "react"; | ||||||||||||||||||||||||||
import { Link } from "react-router-dom"; | ||||||||||||||||||||||||||
import photo from "../../assets/login.png"; | ||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Ashwinib26 you add twice it remove and follow code rabit suggestions |
||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
import { Link, useNavigate } from "react-router-dom"; | ||||||||||||||||||||||||||
import photo from "../../assets/login.png"; | ||||||||||||||||||||||||||
import React, { useState } from "react"; | ||||||||||||||||||||||||||
import { message } from "antd"; | ||||||||||||||||||||||||||
Comment on lines
+2
to
9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct useEffect import, but clean up duplicate imports The addition of Please apply the following changes to clean up the imports: -import React, { useState , useEffect } from "react";
-import { Link } from "react-router-dom";
-import photo from "../../assets/login.png";
-
import { Link, useNavigate } from "react-router-dom";
import photo from "../../assets/login.png";
-import React, { useState } from "react";
+import React, { useState, useEffect } from "react";
import { message } from "antd"; This will remove the duplicate imports and consolidate them into a single, clean import section. 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Biome
|
||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
const Login = () => { | ||||||||||||||||||||||||||
const API_URL = import.meta.env.VITE_BACKEND_URL || "http://localhost:3000"; | ||||||||||||||||||||||||||
const [data, setData] = useState({ | ||||||||||||||||||||||||||
|
@@ -43,6 +49,10 @@ const Login = () => { | |||||||||||||||||||||||||
} | ||||||||||||||||||||||||||
}; | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
useEffect(() => { | ||||||||||||||||||||||||||
window.scrollTo(0, 0); | ||||||||||||||||||||||||||
}, []); | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
return ( | ||||||||||||||||||||||||||
<div className="w-screen h-screen flex items-center justify-center pt-10"> | ||||||||||||||||||||||||||
<img src={photo} alt="login" className=" w-3/4 absolute" /> | ||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved: Effective hover effect added to
.card
class.The hover effect for the
.card
class is well-implemented. It adds a subtle box shadow that provides visual feedback when users interact with card elements, enhancing the overall user experience.However, there's a minor issue to address:
The file is missing a closing brace
}
at the end. Please add it to properly close the.card:hover
rule:.card:hover { box-shadow: 0 8px 16px rgba(0, 0, 0, 0.3); /* Add a shadow on hover */ } + }
🧰 Tools
🪛 Biome