Merge pull request #318 from RamiAwar/fix-new-dsn-on-connection-create

Use dsn from db object when creating new connection
RamiAwar · Sep 5, 2024 · a3c40b6 · a3c40b6
2 parents 58baa98 + e0cda12
commit a3c40b6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/backend/dataline/services/connection.py b/backend/dataline/services/connection.py
@@ -147,6 +147,8 @@ async def create_connection(
     ) -> ConnectionOut:
         # Check if connection can be established before saving it
         db = await self.get_connection_details(dsn)
+        # get potentially modified dsn (eg. if localhost was replaced with host.docker.internal)
+        dsn = str(db._engine.url.render_as_string(hide_password=False))
         if not connection_type:
             connection_type = db.dialect