Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contributor information regarding pre-commit #549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cansik
Copy link
Contributor

@cansik cansik commented Dec 30, 2023

Since it is not clear just because the file is around, I added a short chapter about how to format the code to contribute. Maybe it even makes sense to bump the isort version anyways to at least 5.12.0.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (226d8cc) 74.80% compared to head (1e19269) 74.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   74.80%   74.76%   -0.05%     
==========================================
  Files          71       71              
  Lines        4695     4695              
  Branches      731      731              
==========================================
- Hits         3512     3510       -2     
- Misses        986      987       +1     
- Partials      197      198       +1     
Flag Coverage Δ
unittests 74.76% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cansik
Copy link
Contributor Author

cansik commented Jan 8, 2024

Same issue about nanodet/model/arch/one_stage_detector.py. No idea why this fails now and didn't before. I am only changing the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant