Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category param to clone #9941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Puncher1
Copy link
Contributor

@Puncher1 Puncher1 commented Sep 8, 2024

Summary

This PR adds the category parameter to clone methods.
Solves #9939

This reduces the number of API calls from 2*n + 1 to n + 1, where n is the number of channels, when you want to clone a category with all it's channels.

I've also added the parameter to CategoryChannel.clone to be consistent with the ABC, however I noted it in the docs that in that case the parameter is ignored.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant