Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Server never emit close event if no connection #156

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: Server never emit close event if no connection #156

merged 1 commit into from
Aug 22, 2022

Conversation

hans00
Copy link
Contributor

@hans00 hans00 commented Aug 3, 2022

As title

@hans00 hans00 changed the title Fix server never emit close event if no connection fix: Server never emit close event if no connection Aug 3, 2022
@Rapsssito
Copy link
Owner

@hans00, thanks for the PR! Is this also the behavior of NodeJS' net?

@hans00
Copy link
Contributor Author

hans00 commented Aug 22, 2022

Yes.

sample:
image

@Rapsssito
Copy link
Owner

Fixes #144.

@Rapsssito Rapsssito merged commit 6eec851 into Rapsssito:master Aug 22, 2022
github-actions bot pushed a commit that referenced this pull request Aug 22, 2022
@semantic-release-bot
chore(release): 6.0.1 [skip ci]
5473481 
## [6.0.1](v6.0.0...v6.0.1) (2022-08-22)

### Bug Fixes

* Server never emits close event if no connections ([#156](#156)) ([6eec851](6eec851)), closes [#144](#144)
@github-actions
Copy link

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hans00 @Rapsssito