Don't encourage -rac_liftSelector:withSignals: for subscription
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guideline encourages the use of `-rac_liftSelector:withSignals:` to effect implicit subscription. However, the eager subscription that occurs when that method is called [is regarded as a mistake][0], and [its use to effect implicit subscription is discouraged][1]. [0]: ReactiveCocoa/ReactiveCocoa#1096 (comment) [1]: ReactiveCocoa/ReactiveCocoa#1096 (comment)
mdiep
approved these changes
Feb 1, 2017
erichoracek
added a commit
to erichoracek/ReactiveObjC
that referenced
this pull request
Apr 7, 2017
Includes ReactiveCocoa#75, ReactiveCocoa#80, ReactiveCocoa#81, ReactiveCocoa#82, ReactiveCocoa#83, ReactiveCocoa#85, ReactiveCocoa#87, and ReactiveCocoa#88. As far as I can tell, this should have no breaking changes.
erichoracek
added a commit
to erichoracek/ReactiveObjC
that referenced
this pull request
Apr 7, 2017
Includes ReactiveCocoa#75, ReactiveCocoa#80, ReactiveCocoa#81, ReactiveCocoa#82, ReactiveCocoa#83, ReactiveCocoa#85, ReactiveCocoa#87, and ReactiveCocoa#88. While this has no breaking changes in Obj-C, it will likely introduce breaking changes in Swift.
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
Don't encourage `-rac_liftSelector:withSignals:` for subscription
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
Includes ReactiveCocoa#75, ReactiveCocoa#80, ReactiveCocoa#81, ReactiveCocoa#82, ReactiveCocoa#83, ReactiveCocoa#85, ReactiveCocoa#87, and ReactiveCocoa#88. While this has no breaking changes in Obj-C, it will likely introduce breaking changes in Swift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guideline encourages the use of
-rac_liftSelector:withSignals:toeffect implicit subscription. However, the eager subscription that
occurs when that method is called is regarded as a mistake,
and its use to effect implicit subscription is discouraged.