chore: fix TypeScript latest breakage in CI (#6503)

* chore: appease TS in CI global.gc seems to be possibly undefined in the latest Node types * chore: appease TS * chore: add optional shenanigans
ReactiveX · Jul 5, 2021 · 801a7bb · 801a7bb
1 parent 7ab0a4c
commit 801a7bb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/spec/Subscriber-spec.ts b/spec/Subscriber-spec.ts
@@ -244,7 +244,7 @@ describe('Subscriber', () => {
   });
 
   const FinalizationRegistry = (global as any).FinalizationRegistry;
-  if (FinalizationRegistry) {
+  if (FinalizationRegistry && global.gc) {
 
     it('should not leak the destination', (done) => {
       let observer: Observer<number> | undefined = {
@@ -262,7 +262,7 @@ describe('Subscriber', () => {
       const subscription = of(42).subscribe(observer);
 
       observer = undefined;
-      global.gc();
+      global.gc?.();
     });
 
   } else {

diff --git a/spec/operators/shareReplay-spec.ts b/spec/operators/shareReplay-spec.ts
@@ -366,7 +366,7 @@ describe('shareReplay', () => {
   });
 
   const FinalizationRegistry = (global as any).FinalizationRegistry;
-  if (FinalizationRegistry) {
+  if (FinalizationRegistry && global.gc) {
     it('should not leak the subscriber for sync sources', (done) => {
       let callback: (() => void) | undefined = () => {
         /* noop */
@@ -382,7 +382,7 @@ describe('shareReplay', () => {
       shared.subscribe(callback);
 
       callback = undefined;
-      global.gc();
+      global.gc?.();
     });
   } else {
     console.warn(`No support for FinalizationRegistry in Node ${process.version}`);

diff --git a/spec/schedulers/intervalProvider-spec.ts b/spec/schedulers/intervalProvider-spec.ts
@@ -15,10 +15,10 @@ describe('intervalProvider', () => {
     let setCalled = false;
     let clearCalled = false;
 
-    global.setInterval = () => {
+    global.setInterval = (() => {
       setCalled = true;
       return 0 as any;
-    };
+    }) as any; // TypeScript complains about a __promisify__ property
     global.clearInterval = () => {
       clearCalled = true;
     };