Handle empty response in 'check_ready'

RedHatInsights · Jun 15, 2021 · 1240d37 · 1240d37
1 parent a4c77f2
commit 1240d37
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/bonfire/openshift.py b/bonfire/openshift.py
@@ -404,9 +404,11 @@ def _observe(self, item):
 
     def check_ready(self):
         response = get_json(self.restype, name=self.name, namespace=self.namespace)
-        self._uid = response["metadata"]["uid"]
-        self._observe(response)
-        return all([r["ready"] is True for _, r in self.observed_resources.items()])
+        if response:
+            self._uid = response["metadata"]["uid"]
+            self._observe(response)
+            return all([r["ready"] is True for _, r in self.observed_resources.items()])
+        return False
 
     def _check_with_periodic_log(self):
         if self.check_ready():