Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override frontend auto-added dependencies with BONFIRE_FRONTEND_DEPENDENCIES env var #320

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

bsquizz
Copy link
Collaborator

@bsquizz bsquizz commented Aug 22, 2023

This will allow teams (like HAC team) who don't need all these components pulled in to be able to customize the list by setting the env var, e.g.:

BONFIRE_FRONTEND_DEPENDENCIES="chrome-service,frontend-configs" bonfire deploy <args> --frontends=true

You can also pass an empty value which will cause no frontend dependencies to be pulled in automatically, e.g:

BONFIRE_FRONTEND_DEPENDENCIES="" bonfire deploy <args> --frontends=true

Copy link
Collaborator

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a couple of things may worth revisiting, LMK.

bonfire/config.py Outdated Show resolved Hide resolved
bonfire/config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing, to avoid people shooting themselves in the foot

bonfire/config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsquizz bsquizz force-pushed the override_auto_added_env_vars branch from dba1f12 to ee107fd Compare August 23, 2023 13:12
@bsquizz bsquizz merged commit fa46833 into master Aug 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants