Don't get reservation status for terminating namespaces #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead we should look if the phase is terminating for the namespace and then just omit it from the list. This will require we add a new is_terminating property to Namespace. Gonna do this that way instead. |
adamrdrew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses #316 / RHCLOUD-27918
I looked at this for way too long thinking about all kinds of complex fixes (pass the logger in as a depdency so we can control its log level out at the click commands, split the list namespaces method up into mine and not mine methods to better control what we're doing at run time so we don't need to check reservation status on any !mine namespaces) but in the end I realized we should just do this, always have the log level in
Namespace.reservationbe debug. This information isn't useful to a normal bonfire user; devs or cluster admins can up the log level.