Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIv2): RHINENG-11779 expose os_versions on systems/SGs #2177

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

skateman
Copy link
Member

@skateman skateman commented Aug 6, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman requested a review from a team as a code owner August 6, 2024 14:30
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (a2ef278) to head (fd99f47).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2177   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         232      232           
  Lines        5018     5033   +15     
=======================================
+ Hits         4959     4974   +15     
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skateman
Copy link
Member Author

skateman commented Aug 7, 2024

/retest

2 similar comments
@skateman
Copy link
Member Author

skateman commented Aug 7, 2024

/retest

@LightOfHeaven1994
Copy link
Contributor

/retest

@skateman skateman disabled auto-merge August 7, 2024 14:42
@skateman skateman merged commit 873f1f7 into RedHatInsights:master Aug 7, 2024
8 of 9 checks passed
@skateman skateman deleted the system-os-versions branch August 7, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants