Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(APIv2): RHINENG-11984 search should be a singular field #2185

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(APIv2): RHINENG-11984 search should be a singular field #2185

merged 1 commit into from
Aug 27, 2024

Conversation

skateman
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman requested a review from a team as a code owner August 21, 2024 11:38
LightOfHeaven1994
LightOfHeaven1994 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skateman skateman enabled auto-merge (rebase) August 21, 2024 11:55
@skateman
Copy link
Member Author

/retest

@skateman skateman force-pushed the singular-search branch 2 times, most recently from ef44e61 to d05b697 Compare August 22, 2024 13:05
@LightOfHeaven1994
Copy link
Contributor

/retest

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (31e9073) to head (0e3ede9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2185   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         232      232           
  Lines        5059     5059           
=======================================
  Hits         5000     5000           
  Misses         59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skateman
Copy link
Member Author

/retest

@LightOfHeaven1994
Copy link
Contributor

@skateman feel free to merge it, 1 test failed but unrelated to changes

@skateman skateman disabled auto-merge August 27, 2024 07:42
@skateman skateman merged commit 17c451d into RedHatInsights:master Aug 27, 2024
8 of 9 checks passed
@skateman skateman deleted the singular-search branch August 27, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LightOfHeaven1994 LightOfHeaven1994 LightOfHeaven1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skateman @LightOfHeaven1994