fix(productView): ent-4247 disable take a tour header button (#774)

RedHatInsights · Dec 6, 2021 · 19d3461 · 19d3461
1 parent 9b42a59
commit 19d3461
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 12 deletions.
diff --git a/src/components/pageLayout/pageHeader.js b/src/components/pageLayout/pageHeader.js
@@ -6,6 +6,10 @@ import { ExternalLinkAltIcon } from '@patternfly/react-icons';
 import { helpers } from '../../common';
 import { translate } from '../i18n/i18n';
 
+/**
+ * ToDo: Review removing the "includeTour" prop and associated button code.
+ * ...instead of disabling it, ENT-4247
+ */
 /**
  * Render a platform page header.
  *

diff --git a/src/components/productView/__tests__/__snapshots__/productView.test.js.snap b/src/components/productView/__tests__/__snapshots__/productView.test.js.snap
@@ -5,7 +5,7 @@ exports[`ProductView Component should allow custom product views: custom graphCa
   className=""
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="lorem ipsum product label"
     t={[Function]}
   >
@@ -138,7 +138,7 @@ exports[`ProductView Component should allow custom product views: custom toolbar
   className=""
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="lorem ipsum product label"
     t={[Function]}
   >
@@ -215,7 +215,7 @@ exports[`ProductView Component should allow custom product views: custom toolbar
   className=""
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="lorem ipsum product label"
     t={[Function]}
   >
@@ -292,7 +292,7 @@ exports[`ProductView Component should render a non-connected component: non-conn
   className=""
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="lorem ipsum product label"
     t={[Function]}
   >

diff --git a/src/components/productView/__tests__/__snapshots__/productViewMissing.test.js.snap b/src/components/productView/__tests__/__snapshots__/productViewMissing.test.js.snap
@@ -21,7 +21,7 @@ exports[`ProductViewMissing Component should render a non-connected component: n
   className="curiosity-missing-view"
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="missing"
     t={[Function]}
   >
@@ -151,7 +151,7 @@ exports[`ProductViewMissing Component should render a predictable set of product
   className="curiosity-missing-view"
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="missing"
     t={[Function]}
   >

diff --git a/...components/productView/__tests__/__snapshots__/productViewOpenShiftContainer.test.js.snap b/...components/productView/__tests__/__snapshots__/productViewOpenShiftContainer.test.js.snap
@@ -5,7 +5,7 @@ exports[`ProductViewOpenShiftContainer Component should render a non-connected c
   className=""
 >
   <PageHeader
-    includeTour={true}
+    includeTour={false}
     productLabel="lorem ipsum product label"
     t={[Function]}
   >

diff --git a/src/components/productView/productView.js b/src/components/productView/productView.js
@@ -109,7 +109,7 @@ const ProductView = ({ routeDetail, t, toolbarGraph, toolbarGraphDescription, to
 
   return (
     <PageLayout>
-      <PageHeader productLabel={productLabel} includeTour>
+      <PageHeader productLabel={productLabel}>
         {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME, context: productLabel })}
       </PageHeader>
       <PageMessages>

diff --git a/src/components/productView/productViewMissing.js b/src/components/productView/productViewMissing.js
@@ -49,9 +49,7 @@ const ProductViewMissing = ({ availableProductsRedirect, t }) => {
 
   return (
     <PageLayout className="curiosity-missing-view">
-      <PageHeader productLabel="missing" includeTour>
-        {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME })}
-      </PageHeader>
+      <PageHeader productLabel="missing">{t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME })}</PageHeader>
       <PageSection isFilled>
         <Gallery hasGutter>
           {availableProducts.map(product => (

diff --git a/src/components/productView/productViewOpenShiftContainer.js b/src/components/productView/productViewOpenShiftContainer.js
@@ -162,7 +162,7 @@ const ProductViewOpenShiftContainer = ({ routeDetail, t }) => {
 
   return (
     <PageLayout>
-      <PageHeader productLabel={viewProductLabel} includeTour>
+      <PageHeader productLabel={viewProductLabel}>
         {t(`curiosity-view.title`, { appName: helpers.UI_DISPLAY_NAME, context: viewProductLabel })}
       </PageHeader>
       <PageColumns>{productConfig.map(config => renderProduct(config, uomValue))}</PageColumns>