fix(userSelectors): ent-3825 add report read permissions (#654)

* userSelectors, add check for report read * platformApiTypes, report const
RedHatInsights · May 18, 2021 · 3e5c5c0 · 3e5c5c0
1 parent 3a9188a
commit 3e5c5c0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/redux/selectors/userSelectors.js b/src/redux/selectors/userSelectors.js
@@ -88,7 +88,12 @@ const selector = createDeepEqualSelector([statePropsFilter], response => {
     );
 
     // Alias specific app permissions checks
-    updatedSession.authorized[helpers.UI_NAME] = updatedSession.permissions[APP_TYPES.SUBSCRIPTIONS]?.all || false;
+    updatedSession.authorized[helpers.UI_NAME] =
+      updatedSession.permissions[APP_TYPES.SUBSCRIPTIONS]?.all ||
+      Array.isArray(
+        updatedSession.permissions[APP_TYPES.SUBSCRIPTIONS]?.resources?.[RESOURCE_TYPES.REPORTS]?.[OPERATION_TYPES.READ]
+      ) ||
+      false;
 
     updatedSession.authorized.inventory =
       updatedSession.permissions[APP_TYPES.INVENTORY]?.all ||

diff --git a/src/types/__tests__/__snapshots__/index.test.js.snap b/src/types/__tests__/__snapshots__/index.test.js.snap
@@ -27,6 +27,7 @@ Object {
       "PLATFORM_API_RESPONSE_USER_PERMISSION_RESOURCE_TYPES": Object {
         "ALL": "*",
         "HOSTS": "hosts",
+        "REPORTS": "reports",
       },
       "PLATFORM_API_RESPONSE_USER_PERMISSION_TYPES": Object {
         "PERMISSION": "permission",
@@ -265,6 +266,7 @@ Object {
       "PLATFORM_API_RESPONSE_USER_PERMISSION_RESOURCE_TYPES": Object {
         "ALL": "*",
         "HOSTS": "hosts",
+        "REPORTS": "reports",
       },
       "PLATFORM_API_RESPONSE_USER_PERMISSION_TYPES": Object {
         "PERMISSION": "permission",
@@ -502,6 +504,7 @@ Object {
     "PLATFORM_API_RESPONSE_USER_PERMISSION_RESOURCE_TYPES": Object {
       "ALL": "*",
       "HOSTS": "hosts",
+      "REPORTS": "reports",
     },
     "PLATFORM_API_RESPONSE_USER_PERMISSION_TYPES": Object {
       "PERMISSION": "permission",
@@ -743,6 +746,7 @@ Object {
     "PLATFORM_API_RESPONSE_USER_PERMISSION_RESOURCE_TYPES": Object {
       "ALL": "*",
       "HOSTS": "hosts",
+      "REPORTS": "reports",
     },
     "PLATFORM_API_RESPONSE_USER_PERMISSION_TYPES": Object {
       "PERMISSION": "permission",

diff --git a/src/types/platformApiTypes.js b/src/types/platformApiTypes.js
@@ -46,7 +46,7 @@ const PLATFORM_API_RESPONSE_USER_IDENTITY_USER_TYPES = {
  * Platform response of USER PERMISSION type values.
  * Schema/map of expected response identity user permission types.
  *
- * @type {{PERMISSION: string}}
+ * @type {{PERMISSION: string, RESOURCE_DEFS: string}}
  */
 const PLATFORM_API_RESPONSE_USER_PERMISSION_TYPES = {
   PERMISSION: 'permission',
@@ -60,7 +60,8 @@ const PLATFORM_API_RESPONSE_USER_PERMISSION_APP_TYPES = {
 
 const PLATFORM_API_RESPONSE_USER_PERMISSION_RESOURCE_TYPES = {
   ALL: '*',
-  HOSTS: 'hosts'
+  HOSTS: 'hosts',
+  REPORTS: 'reports'
 };
 
 const PLATFORM_API_RESPONSE_USER_PERMISSION_OPERATION_TYPES = {