fix(inventoryList): issues/403 minHeight update on perpage (#447)

RedHatInsights · Oct 26, 2020 · 4194200 · 4194200
1 parent 2576854
commit 4194200
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/components/inventoryList/__tests__/__snapshots__/inventoryList.test.js.snap b/src/components/inventoryList/__tests__/__snapshots__/inventoryList.test.js.snap
@@ -127,6 +127,7 @@ exports[`InventoryList Component should handle variations in data: filtered data
 >
   <MinHeight
     autoUpdate={true}
+    key="headerMinHeight"
     minHeight={0}
   >
     <CardHeader>
@@ -152,6 +153,7 @@ exports[`InventoryList Component should handle variations in data: filtered data
   </MinHeight>
   <MinHeight
     autoUpdate={true}
+    key="bodyMinHeight-10"
     minHeight={0}
   >
     <CardBody>
@@ -193,6 +195,7 @@ exports[`InventoryList Component should handle variations in data: filtered data
   </MinHeight>
   <MinHeight
     autoUpdate={true}
+    key="footerMinHeight"
     minHeight={0}
   >
     <CardFooter
@@ -221,6 +224,7 @@ exports[`InventoryList Component should handle variations in data: variable data
 >
   <MinHeight
     autoUpdate={true}
+    key="headerMinHeight"
     minHeight={0}
   >
     <CardHeader>
@@ -246,6 +250,7 @@ exports[`InventoryList Component should handle variations in data: variable data
   </MinHeight>
   <MinHeight
     autoUpdate={true}
+    key="bodyMinHeight-10"
     minHeight={0}
   >
     <CardBody>
@@ -290,6 +295,7 @@ exports[`InventoryList Component should handle variations in data: variable data
   </MinHeight>
   <MinHeight
     autoUpdate={true}
+    key="footerMinHeight"
     minHeight={0}
   >
     <CardFooter
@@ -318,6 +324,7 @@ exports[`InventoryList Component should render a non-connected component: non-co
 >
   <MinHeight
     autoUpdate={true}
+    key="headerMinHeight"
     minHeight={0}
   >
     <CardHeader>
@@ -343,6 +350,7 @@ exports[`InventoryList Component should render a non-connected component: non-co
   </MinHeight>
   <MinHeight
     autoUpdate={true}
+    key="bodyMinHeight-10"
     minHeight={0}
   >
     <CardBody>
@@ -365,6 +373,7 @@ exports[`InventoryList Component should render a non-connected component: non-co
   </MinHeight>
   <MinHeight
     autoUpdate={true}
+    key="footerMinHeight"
     minHeight={0}
   >
     <CardFooter

diff --git a/src/components/inventoryList/inventoryList.js b/src/components/inventoryList/inventoryList.js
@@ -165,7 +165,7 @@ class InventoryList extends React.Component {
 
     return (
       <Card className="curiosity-inventory-card">
-        <MinHeight>
+        <MinHeight key="headerMinHeight">
           <CardHeader>
             <CardTitle>
               <Title headingLevel="h2" size="lg">
@@ -184,7 +184,7 @@ class InventoryList extends React.Component {
             </CardActions>
           </CardHeader>
         </MinHeight>
-        <MinHeight>
+        <MinHeight key={`bodyMinHeight-${updatedPerPage}`}>
           <CardBody>
             <div className={(error && 'blur') || 'fadein'}>
               {pending && (
@@ -202,7 +202,7 @@ class InventoryList extends React.Component {
             </div>
           </CardBody>
         </MinHeight>
-        <MinHeight>
+        <MinHeight key="footerMinHeight">
           <CardFooter className={(error && 'blur') || ''}>
             <TableToolbar isFooter>
               <Pagination