fix(helpers): add isDate check, enhance isPromise

* helpers, isDate, enhance isPromise, async promise-like check
RedHatInsights · Jul 30, 2020 · 82d823b · 82d823b
1 parent 611df87
commit 82d823b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/src/common/__tests__/__snapshots__/helpers.test.js.snap b/src/common/__tests__/__snapshots__/helpers.test.js.snap
@@ -23,6 +23,7 @@ Object {
   "UI_WINDOW_ID": "curiosity",
   "browserExpose": [Function],
   "generateId": [Function],
+  "isDate": [Function],
   "isPromise": [Function],
   "lorem": "ipsum",
   "noop": [Function],
@@ -54,6 +55,7 @@ Object {
   "UI_WINDOW_ID": "curiosity",
   "browserExpose": [Function],
   "generateId": [Function],
+  "isDate": [Function],
   "isPromise": [Function],
   "lorem": "ipsum",
   "noop": [Function],
@@ -85,6 +87,7 @@ Object {
   "UI_WINDOW_ID": "curiosity",
   "browserExpose": [Function],
   "generateId": [Function],
+  "isDate": [Function],
   "isPromise": [Function],
   "noop": [Function],
   "noopPromise": Promise {},

diff --git a/src/common/__tests__/helpers.test.js b/src/common/__tests__/helpers.test.js
@@ -10,8 +10,16 @@ describe('Helpers', () => {
     expect(helpers.generateId('lorem')).toBe('lorem-');
   });
 
+  it('should determine a date', () => {
+    expect(helpers.isDate(new Date('broken'))).toBe(true);
+    expect(helpers.isDate(Date)).toBe(false);
+    expect(helpers.isDate(1)).toBe(false);
+    expect(helpers.isDate('lorem')).toBe(false);
+  });
+
   it('should determine a promise', () => {
     expect(helpers.isPromise(Promise.resolve())).toBe(true);
+    expect(helpers.isPromise(async () => {})).toBe(true);
     expect(helpers.isPromise(() => 'lorem')).toBe(false);
   });
 

diff --git a/src/common/helpers.js b/src/common/helpers.js
@@ -7,14 +7,21 @@
 const generateId = prefix =>
   `${prefix || 'generatedid'}-${(process.env.REACT_APP_ENV !== 'test' && Math.ceil(1e5 * Math.random())) || ''}`;
 
-// ToDo: expand to include "async" check in scenarios where async/await are utilized.
 /**
- * Check if "is a Promise".
+ * Check if "is a Date"
+ *
+ * @param {Date|*} date
+ * @returns {boolean}
+ */
+const isDate = date => Object.prototype.toString.call(date) === '[object Date]';
+
+/**
+ * Check if "is a Promise", "Promise like".
  *
  * @param {Promise|*} obj
  * @returns {boolean}
  */
-const isPromise = obj => Object.prototype.toString.call(obj) === '[object Promise]';
+const isPromise = obj => /^\[object (Promise|Async|AsyncFunction)]/.test(Object.prototype.toString.call(obj));
 
 /**
  * An empty function.
@@ -210,6 +217,7 @@ const browserExpose = (obj = {}, options) => {
 const helpers = {
   browserExpose,
   generateId,
+  isDate,
   isPromise,
   noop,
   noopPromise,