Skip to content

Commit

Permalink
fix(table,tableSkeleton): issues/10 align content prop to pf (#372)
Browse files Browse the repository at this point in the history 
* table, pf fixme annotations, align to pf title/content prop
* tableSkeleton, switch to generic node, related to pf title align
  • Loading branch information
@cdcabrera
cdcabrera committed Sep 29, 2020
1 parent ff7d33c commit 88e1140
Show file tree
Hide file tree
Showing 4 changed files with 172 additions and 145 deletions.
50 changes: 33 additions & 17 deletions src/components/table/__tests__/__snapshots__/table.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ exports[`Table Component should allow expandable content: expandable content 1`]
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table "
Expand Down Expand Up @@ -81,7 +83,9 @@ exports[`Table Component should allow expandable content: expanded row 1`] = `
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table "
Expand Down Expand Up @@ -148,7 +152,9 @@ exports[`Table Component should allow variations in table layout: ariaLabel and
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table-no-border "
Expand All @@ -158,7 +164,6 @@ exports[`Table Component should allow variations in table layout: ariaLabel and
expandId="expandable-toggle"
gridBreakPoint="grid-md"
isStickyHeader={false}
onCollapse={[Function]}
ouiaSafe={true}
role="grid"
rowLabeledBy="simple-node"
Expand Down Expand Up @@ -203,7 +208,9 @@ exports[`Table Component should allow variations in table layout: borders and ta
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table-no-border "
Expand All @@ -213,7 +220,6 @@ exports[`Table Component should allow variations in table layout: borders and ta
expandId="expandable-toggle"
gridBreakPoint="grid-md"
isStickyHeader={false}
onCollapse={[Function]}
ouiaSafe={true}
role="grid"
rowLabeledBy="simple-node"
Expand Down Expand Up @@ -258,7 +264,9 @@ exports[`Table Component should allow variations in table layout: className and
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table-no-border lorem-ipsum-class"
Expand All @@ -268,7 +276,6 @@ exports[`Table Component should allow variations in table layout: className and
expandId="expandable-toggle"
gridBreakPoint="grid-md"
isStickyHeader={false}
onCollapse={[Function]}
ouiaSafe={true}
role="grid"
rowLabeledBy="simple-node"
Expand Down Expand Up @@ -313,7 +320,9 @@ exports[`Table Component should allow variations in table layout: generated rows
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table "
Expand All @@ -323,7 +332,6 @@ exports[`Table Component should allow variations in table layout: generated rows
expandId="expandable-toggle"
gridBreakPoint="grid-md"
isStickyHeader={false}
onCollapse={[Function]}
ouiaSafe={true}
role="grid"
rowLabeledBy="simple-node"
Expand Down Expand Up @@ -369,7 +377,9 @@ exports[`Table Component should pass child components, nodes when there are no r
canSelectAll={true}
cells={
Array [
"lorem ipsum",
Object {
"title": "lorem ipsum",
},
]
}
className="curiosity-table "
Expand All @@ -379,7 +389,6 @@ exports[`Table Component should pass child components, nodes when there are no r
expandId="expandable-toggle"
gridBreakPoint="grid-md"
isStickyHeader={false}
onCollapse={[Function]}
ouiaSafe={true}
role="grid"
rowLabeledBy="simple-node"
Expand Down Expand Up @@ -409,10 +418,18 @@ exports[`Table Component should render a non-connected component: non-connected
canSelectAll={true}
cells={
Array [
"lorem",
"ipsum",
"dolor",
"sit",
Object {
"title": "lorem",
},
Object {
"title": "ipsum",
},
Object {
"title": "dolor",
},
Object {
"title": "sit",
},
]
}
className="curiosity-table "
Expand All @@ -422,7 +439,6 @@ exports[`Table Component should render a non-connected component: non-connected
expandId="expandable-toggle"
gridBreakPoint="grid-md"
isStickyHeader={false}
onCollapse={[Function]}
ouiaSafe={true}
role="grid"
rowLabeledBy="simple-node"
Expand Down
200 changes: 80 additions & 120 deletions src/components/table/__tests__/__snapshots__/tableSkeleton.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,36 +34,26 @@ exports[`TableSkeleton Component should allow variations in table layout: border
Array [
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
],
},
]
Expand Down Expand Up @@ -108,36 +98,26 @@ exports[`TableSkeleton Component should allow variations in table layout: classN
Array [
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
],
},
]
Expand Down Expand Up @@ -182,36 +162,26 @@ exports[`TableSkeleton Component should allow variations in table layout: column
Array [
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
<Skeleton
isDark={false}
size="md"
/>,
],
},
]
Expand Down Expand Up @@ -240,52 +210,42 @@ exports[`TableSkeleton Component should render a non-connected component: non-co
Array [
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
],
},
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
],
},
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
],
},
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
],
},
Object {
"cells": Array [
Object {
"cell": <Skeleton
isDark={false}
size="md"
/>,
},
<Skeleton
isDark={false}
size="md"
/>,
],
},
]
Expand Down
Loading

0 comments on commit 88e1140

Please sign in to comment.