fix(reduxHelpers): response message status range (#570)

* reduxHelpers, avoid caching large responses on emulated 304
RedHatInsights · Feb 16, 2021 · 9427794 · 9427794
1 parent a4b5cda
commit 9427794
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/redux/common/__tests__/__snapshots__/reduxHelpers.test.js.snap b/src/redux/common/__tests__/__snapshots__/reduxHelpers.test.js.snap
@@ -202,6 +202,8 @@ exports[`ReduxHelpers should get a http status from a service call response: sta
 
 exports[`ReduxHelpers should get a message from a service call response: 3XX fallback message 1`] = `"Multiple Choices"`;
 
+exports[`ReduxHelpers should get a message from a service call response: 3XX, 304 fallback message 1`] = `"Not modified"`;
+
 exports[`ReduxHelpers should get a message from a service call response: 4XX fallback message 1`] = `"Bad Request"`;
 
 exports[`ReduxHelpers should get a message from a service call response: 5XX fallback message 1`] = `"Internal Server Error"`;

diff --git a/src/redux/common/__tests__/reduxHelpers.test.js b/src/redux/common/__tests__/reduxHelpers.test.js
@@ -145,6 +145,16 @@ describe('ReduxHelpers', () => {
       })
     ).toMatchSnapshot('3XX fallback message');
 
+    expect(
+      reduxHelpers.getMessageFromResults({
+        response: {
+          data: { lorem: 'ipsum', dolor: 'sit' },
+          status: 304,
+          statusText: 'Not modified'
+        }
+      })
+    ).toMatchSnapshot('3XX, 304 fallback message');
+
     expect(
       reduxHelpers.getMessageFromResults({
         response: {

diff --git a/src/redux/common/reduxHelpers.js b/src/redux/common/reduxHelpers.js
@@ -192,7 +192,7 @@ const getMessageFromResults = results => {
     return `${formattedStatus}${dataResponse}`.trim();
   }
 
-  if (status >= 300 && _isPlainObject(dataResponse)) {
+  if (status >= 400 && _isPlainObject(dataResponse)) {
     return `${formattedStatus}${JSON.stringify(dataResponse)}`;
   }