fix(rhsmServices,redux): issues/10 inventory guests, state (#330)

* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests

.env

@@ -29,4 +29,5 @@ REACT_APP_SERVICES_RHSM_VERSION=/api/rhsm-subscriptions/v1/version
 REACT_APP_SERVICES_RHSM_REPORT=/api/rhsm-subscriptions/v1/tally/products/
 REACT_APP_SERVICES_RHSM_CAPACITY=/api/rhsm-subscriptions/v1/capacity/products/
 REACT_APP_SERVICES_RHSM_INVENTORY=/api/rhsm-subscriptions/v1/hosts/products/
+REACT_APP_SERVICES_RHSM_INVENTORY_GUESTS=/api/rhsm-subscriptions/v1/hosts/{0}/guests
 REACT_APP_SERVICES_RHSM_OPTIN=/api/rhsm-subscriptions/v1/opt-in

.env.development

@@ -11,4 +11,5 @@ REACT_APP_SERVICES_RHSM_VERSION=http://localhost:5000/api/rhsm-subscriptions/v1/
 REACT_APP_SERVICES_RHSM_REPORT=http://localhost:5000/api/rhsm-subscriptions/v1/tally/products/
 REACT_APP_SERVICES_RHSM_CAPACITY=http://localhost:5000/api/rhsm-subscriptions/v1/capacity/products/
 REACT_APP_SERVICES_RHSM_INVENTORY=http://localhost:5000/api/rhsm-subscriptions/v1/hosts/products/
+REACT_APP_SERVICES_RHSM_INVENTORY_GUESTS=//localhost:5000/api/rhsm-subscriptions/v1/hosts/{0}/guests
 REACT_APP_SERVICES_RHSM_OPTIN=http://localhost:5000/api/rhsm-subscriptions/v1/opt-in

.env.proxy

@@ -15,4 +15,5 @@ REACT_APP_SERVICES_RHSM_VERSION=/api/rhsm-subscriptions/v1/version
 REACT_APP_SERVICES_RHSM_REPORT=/api/rhsm-subscriptions/v1/tally/products/
 REACT_APP_SERVICES_RHSM_CAPACITY=/api/rhsm-subscriptions/v1/capacity/products/
 REACT_APP_SERVICES_RHSM_INVENTORY=/api/rhsm-subscriptions/v1/hosts/products/
+REACT_APP_SERVICES_RHSM_INVENTORY_GUESTS=/api/rhsm-subscriptions/v1/hosts/{0}/guests
 REACT_APP_SERVICES_RHSM_OPTIN=/api/rhsm-subscriptions/v1/opt-in

src/redux/actions/__tests__/rhsmActions.test.js

@@ -56,4 +56,15 @@ describe('RhsmActions', () => {
       done();
     });
   });
+
+  it('Should return response content for getHostsInventoryGuests method', done => {
+    const store = generateStore();
+    const dispatcher = rhsmActions.getHostsInventoryGuests();
+
+    dispatcher(store.dispatch).then(() => {
+      const response = store.getState().inventory;
+      expect(response.hostsInventoryGuests.fulfilled).toBe(true);
+      done();
+    });
+  });
 });

src/redux/actions/rhsmActions.js

@@ -19,6 +19,13 @@ const getGraphReportsCapacity = (id = null, query = {}) => dispatch =>
     }
   });
 
+/**
+ * Get a hosts response listing from RHSM subscriptions.
+ *
+ * @param {string} id
+ * @param {object} query
+ * @returns {Function}
+ */
 const getHostsInventory = (id = null, query = {}) => dispatch =>
   dispatch({
     type: rhsmTypes.GET_HOSTS_INVENTORY_RHSM,
@@ -30,6 +37,24 @@ const getHostsInventory = (id = null, query = {}) => dispatch =>
     }
   });
 
-const rhsmActions = { getGraphReportsCapacity, getHostsInventory };
+/**
+ * Get a host's guest response listing from RHSM subscriptions.
+ *
+ * @param {string} id
+ * @param {object} query
+ * @returns {Function}
+ */
+const getHostsInventoryGuests = (id = null, query = {}) => dispatch =>
+  dispatch({
+    type: rhsmTypes.GET_HOSTS_INVENTORY_GUESTS_RHSM,
+    payload: rhsmServices.getHostsInventoryGuests(id, query),
+    meta: {
+      id,
+      query,
+      notifications: {}
+    }
+  });
+
+const rhsmActions = { getGraphReportsCapacity, getHostsInventory, getHostsInventoryGuests };
 
-export { rhsmActions as default, rhsmActions, getGraphReportsCapacity, getHostsInventory };
+export { rhsmActions as default, rhsmActions, getGraphReportsCapacity, getHostsInventory, getHostsInventoryGuests };

src/redux/reducers/__tests__/__snapshots__/inventoryReducer.test.js.snap

@@ -1,5 +1,25 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`InventoryReducer should handle all defined error types: rejected types GET_HOSTS_INVENTORY_GUESTS_RHSM 1`] = `
+Object {
+  "result": Object {
+    "hostsInventory": Object {},
+    "hostsInventoryGuests": Object {
+      "error": true,
+      "errorMessage": "MESSAGE",
+      "fulfilled": false,
+      "meta": Object {},
+      "metaData": undefined,
+      "metaId": undefined,
+      "metaQuery": undefined,
+      "pending": false,
+      "status": 0,
+    },
+  },
+  "type": "GET_HOSTS_INVENTORY_GUESTS_RHSM_REJECTED",
+}
+`;
+
 exports[`InventoryReducer should handle all defined error types: rejected types GET_HOSTS_INVENTORY_RHSM 1`] = `
 Object {
   "result": Object {
@@ -14,11 +34,36 @@ Object {
       "pending": false,
       "status": 0,
     },
+    "hostsInventoryGuests": Object {},
   },
   "type": "GET_HOSTS_INVENTORY_RHSM_REJECTED",
 }
 `;
 
+exports[`InventoryReducer should handle all defined fulfilled types: fulfilled types GET_HOSTS_INVENTORY_GUESTS_RHSM 1`] = `
+Object {
+  "result": Object {
+    "hostsInventory": Object {},
+    "hostsInventoryGuests": Object {
+      "data": Object {
+        "test": "success",
+      },
+      "date": null,
+      "error": false,
+      "errorMessage": "",
+      "fulfilled": true,
+      "meta": Object {},
+      "metaData": undefined,
+      "metaId": undefined,
+      "metaQuery": undefined,
+      "pending": false,
+      "status": 0,
+    },
+  },
+  "type": "GET_HOSTS_INVENTORY_GUESTS_RHSM_FULFILLED",
+}
+`;
+
 exports[`InventoryReducer should handle all defined fulfilled types: fulfilled types GET_HOSTS_INVENTORY_RHSM 1`] = `
 Object {
   "result": Object {
@@ -37,11 +82,31 @@ Object {
       "pending": false,
       "status": 0,
     },
+    "hostsInventoryGuests": Object {},
   },
   "type": "GET_HOSTS_INVENTORY_RHSM_FULFILLED",
 }
 `;
 
+exports[`InventoryReducer should handle all defined pending types: pending types GET_HOSTS_INVENTORY_GUESTS_RHSM 1`] = `
+Object {
+  "result": Object {
+    "hostsInventory": Object {},
+    "hostsInventoryGuests": Object {
+      "error": false,
+      "errorMessage": "",
+      "fulfilled": false,
+      "meta": Object {},
+      "metaData": undefined,
+      "metaId": undefined,
+      "metaQuery": undefined,
+      "pending": true,
+    },
+  },
+  "type": "GET_HOSTS_INVENTORY_GUESTS_RHSM_PENDING",
+}
+`;
+
 exports[`InventoryReducer should handle all defined pending types: pending types GET_HOSTS_INVENTORY_RHSM 1`] = `
 Object {
   "result": Object {
@@ -55,6 +120,7 @@ Object {
       "metaQuery": undefined,
       "pending": true,
     },
+    "hostsInventoryGuests": Object {},
   },
   "type": "GET_HOSTS_INVENTORY_RHSM_PENDING",
 }

src/redux/reducers/__tests__/inventoryReducer.test.js

@@ -8,7 +8,7 @@ describe('InventoryReducer', () => {
   });
 
   it('should handle all defined error types', () => {
-    const specificTypes = [types.GET_HOSTS_INVENTORY_RHSM];
+    const specificTypes = [types.GET_HOSTS_INVENTORY_RHSM, types.GET_HOSTS_INVENTORY_GUESTS_RHSM];
 
     specificTypes.forEach(value => {
       const dispatched = {
@@ -35,7 +35,7 @@ describe('InventoryReducer', () => {
   });
 
   it('should handle all defined pending types', () => {
-    const specificTypes = [types.GET_HOSTS_INVENTORY_RHSM];
+    const specificTypes = [types.GET_HOSTS_INVENTORY_RHSM, types.GET_HOSTS_INVENTORY_GUESTS_RHSM];
 
     specificTypes.forEach(value => {
       const dispatched = {
@@ -51,7 +51,7 @@ describe('InventoryReducer', () => {
   });
 
   it('should handle all defined fulfilled types', () => {
-    const specificTypes = [types.GET_HOSTS_INVENTORY_RHSM];
+    const specificTypes = [types.GET_HOSTS_INVENTORY_RHSM, types.GET_HOSTS_INVENTORY_GUESTS_RHSM];
 
     specificTypes.forEach(value => {
       const dispatched = {

src/redux/reducers/inventoryReducer.js

@@ -5,22 +5,26 @@ import { reduxHelpers } from '../common/reduxHelpers';
  * Initial state.
  *
  * @private
- * @type {{inventory: {}}}
+ * @type {{hostsInventoryGuests: {}, hostsInventory: {}}}
  */
 const initialState = {
-  hostsInventory: {}
+  hostsInventory: {},
+  hostsInventoryGuests: {}
 };
 
 /**
- * Apply generated inventory observer/reducer for systemInventory to state, against actions.
+ * Apply generated inventory observer/reducer for hosts/system inventory to state, against actions.
  *
  * @param {object} state
  * @param {object} action
  * @returns {object|{}}
  */
 const inventoryReducer = (state = initialState, action) =>
   reduxHelpers.generatedPromiseActionReducer(
-    [{ ref: 'hostsInventory', type: rhsmTypes.GET_HOSTS_INVENTORY_RHSM }],
+    [
+      { ref: 'hostsInventory', type: rhsmTypes.GET_HOSTS_INVENTORY_RHSM },
+      { ref: 'hostsInventoryGuests', type: rhsmTypes.GET_HOSTS_INVENTORY_GUESTS_RHSM }
+    ],
     state,
     action
   );

src/redux/types/__tests__/__snapshots__/index.test.js.snap

@@ -27,6 +27,7 @@ Object {
       "GET_GRAPH_CAPACITY_RHSM": "GET_GRAPH_CAPACITY_RHSM",
       "GET_GRAPH_REPORT_CAPACITY_RHSM": "GET_GRAPH_REPORT_CAPACITY_RHSM",
       "GET_GRAPH_REPORT_RHSM": "GET_GRAPH_REPORT_RHSM",
+      "GET_HOSTS_INVENTORY_GUESTS_RHSM": "GET_HOSTS_INVENTORY_GUESTS_RHSM",
       "GET_HOSTS_INVENTORY_RHSM": "GET_HOSTS_INVENTORY_RHSM",
       "SET_GRAPH_GRANULARITY_RHSM": "SET_GRAPH_GRANULARITY_RHSM",
       "SET_GRAPH_SLA_RHSM": "SET_GRAPH_SLA_RHSM",
@@ -73,6 +74,7 @@ Object {
       "GET_GRAPH_CAPACITY_RHSM": "GET_GRAPH_CAPACITY_RHSM",
       "GET_GRAPH_REPORT_CAPACITY_RHSM": "GET_GRAPH_REPORT_CAPACITY_RHSM",
       "GET_GRAPH_REPORT_RHSM": "GET_GRAPH_REPORT_RHSM",
+      "GET_HOSTS_INVENTORY_GUESTS_RHSM": "GET_HOSTS_INVENTORY_GUESTS_RHSM",
       "GET_HOSTS_INVENTORY_RHSM": "GET_HOSTS_INVENTORY_RHSM",
       "SET_GRAPH_GRANULARITY_RHSM": "SET_GRAPH_GRANULARITY_RHSM",
       "SET_GRAPH_SLA_RHSM": "SET_GRAPH_SLA_RHSM",
@@ -90,6 +92,7 @@ Object {
     "GET_GRAPH_CAPACITY_RHSM": "GET_GRAPH_CAPACITY_RHSM",
     "GET_GRAPH_REPORT_CAPACITY_RHSM": "GET_GRAPH_REPORT_CAPACITY_RHSM",
     "GET_GRAPH_REPORT_RHSM": "GET_GRAPH_REPORT_RHSM",
+    "GET_HOSTS_INVENTORY_GUESTS_RHSM": "GET_HOSTS_INVENTORY_GUESTS_RHSM",
     "GET_HOSTS_INVENTORY_RHSM": "GET_HOSTS_INVENTORY_RHSM",
     "SET_GRAPH_GRANULARITY_RHSM": "SET_GRAPH_GRANULARITY_RHSM",
     "SET_GRAPH_SLA_RHSM": "SET_GRAPH_SLA_RHSM",
@@ -127,6 +130,7 @@ Object {
     "GET_GRAPH_CAPACITY_RHSM": "GET_GRAPH_CAPACITY_RHSM",
     "GET_GRAPH_REPORT_CAPACITY_RHSM": "GET_GRAPH_REPORT_CAPACITY_RHSM",
     "GET_GRAPH_REPORT_RHSM": "GET_GRAPH_REPORT_RHSM",
+    "GET_HOSTS_INVENTORY_GUESTS_RHSM": "GET_HOSTS_INVENTORY_GUESTS_RHSM",
     "GET_HOSTS_INVENTORY_RHSM": "GET_HOSTS_INVENTORY_RHSM",
     "SET_GRAPH_GRANULARITY_RHSM": "SET_GRAPH_GRANULARITY_RHSM",
     "SET_GRAPH_SLA_RHSM": "SET_GRAPH_SLA_RHSM",

src/redux/types/rhsmTypes.js

@@ -2,21 +2,23 @@ const GET_GRAPH_CAPACITY_RHSM = 'GET_GRAPH_CAPACITY_RHSM';
 const GET_GRAPH_REPORT_RHSM = 'GET_GRAPH_REPORT_RHSM';
 const GET_GRAPH_REPORT_CAPACITY_RHSM = 'GET_GRAPH_REPORT_CAPACITY_RHSM';
 const GET_HOSTS_INVENTORY_RHSM = 'GET_HOSTS_INVENTORY_RHSM';
+const GET_HOSTS_INVENTORY_GUESTS_RHSM = 'GET_HOSTS_INVENTORY_GUESTS_RHSM';
 const SET_GRAPH_GRANULARITY_RHSM = 'SET_GRAPH_GRANULARITY_RHSM';
 const SET_GRAPH_SLA_RHSM = 'SET_GRAPH_SLA_RHSM';
 
 /**
  * RHSM API action, reducer types.
  *
  * @type {{GET_GRAPH_REPORT_CAPACITY_RHSM: string, SET_GRAPH_GRANULARITY_RHSM: string,
- *     GET_GRAPH_CAPACITY_RHSM: string, SET_GRAPH_SLA_RHSM: string, GET_HOSTS_INVENTORY_RHSM: string,
- *     GET_GRAPH_REPORT_RHSM: string}}
+ *     GET_HOSTS_INVENTORY_GUESTS_RHSM: string, GET_GRAPH_CAPACITY_RHSM: string, SET_GRAPH_SLA_RHSM: string,
+ *     GET_HOSTS_INVENTORY_RHSM: string, GET_GRAPH_REPORT_RHSM: string}}
  */
 const rhsmTypes = {
   GET_GRAPH_CAPACITY_RHSM,
   GET_GRAPH_REPORT_RHSM,
   GET_GRAPH_REPORT_CAPACITY_RHSM,
   GET_HOSTS_INVENTORY_RHSM,
+  GET_HOSTS_INVENTORY_GUESTS_RHSM,
   SET_GRAPH_GRANULARITY_RHSM,
   SET_GRAPH_SLA_RHSM
 };
@@ -28,6 +30,7 @@ export {
   GET_GRAPH_REPORT_RHSM,
   GET_GRAPH_REPORT_CAPACITY_RHSM,
   GET_HOSTS_INVENTORY_RHSM,
+  GET_HOSTS_INVENTORY_GUESTS_RHSM,
   SET_GRAPH_GRANULARITY_RHSM,
   SET_GRAPH_SLA_RHSM
 };

src/services/__tests__/rhsmServices.test.js

@@ -17,14 +17,15 @@ describe('RhsmServices', () => {
   });
 
   it('should export a specific number of methods and classes', () => {
-    expect(Object.keys(rhsmServices)).toHaveLength(4);
+    expect(Object.keys(rhsmServices)).toHaveLength(5);
   });
 
   it('should have specific methods', () => {
     expect(rhsmServices.getApiVersion).toBeDefined();
     expect(rhsmServices.getGraphCapacity).toBeDefined();
     expect(rhsmServices.getGraphReports).toBeDefined();
     expect(rhsmServices.getHostsInventory).toBeDefined();
+    expect(rhsmServices.getHostsInventoryGuests).toBeDefined();
   });
 
   /**